From 5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Thu, 25 Feb 2016 10:48:10 -0800 Subject: cleanup: Add warning comment to gpio.inc files With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury --- board/hadoken/gpio.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'board/hadoken') diff --git a/board/hadoken/gpio.inc b/board/hadoken/gpio.inc index eb8be3d3f4..33e6ab6a7a 100644 --- a/board/hadoken/gpio.inc +++ b/board/hadoken/gpio.inc @@ -5,11 +5,12 @@ * found in the LICENSE file. */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + #define GPIO_KB_INPUT (GPIO_INPUT | GPIO_PULL_UP | GPIO_INT_BOTH) #define GPIO_KB_OUTPUT GPIO_ODR_HIGH -/* Inputs with interrupt handlers are first for efficiency */ - /* Keyboard inputs */ /* * TODO(yjlou): call keyboard_raw_gpio_interrupt() in chip/nrf51/keyboard_raw.c -- cgit v1.2.1