From db63fb74ee0e4bc7c611033851759b41f44642fd Mon Sep 17 00:00:00 2001 From: Tommy Chung Date: Thu, 14 Oct 2021 09:15:15 +0800 Subject: battery: Move battery get/set vendor param to common/battery.c Since the functions are copied by many boards, move them to common. The specific param regs are defined in each specific boards. BUG=b:203031618 BRANCH=none TEST=make BOARD=burnet/coachz/eve/homestar/kappa/mrbland/quackingstick/ wormdingler. Signed-off-by: Tommy Chung Change-Id: I77c070663ad3e800ec484bd21865c5d911a2c48b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3220718 Reviewed-by: Daisuke Nojiri --- board/homestar/battery.c | 6 ++++++ board/homestar/board.c | 22 ---------------------- 2 files changed, 6 insertions(+), 22 deletions(-) (limited to 'board/homestar') diff --git a/board/homestar/battery.c b/board/homestar/battery.c index b1a05809f0..a4e8f793ae 100644 --- a/board/homestar/battery.c +++ b/board/homestar/battery.c @@ -60,6 +60,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 45, .discharging_min_c = -10, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, /* COSMX GH02047XL */ @@ -89,6 +90,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 45, .discharging_min_c = -10, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, /* COSMX DS02032XL */ @@ -118,6 +120,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 45, .discharging_min_c = -10, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, /* SMP DS02032XL */ @@ -147,6 +150,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 45, .discharging_min_c = -10, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, /* Sunwoda L21D4PG0 */ @@ -176,6 +180,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 60, .discharging_min_c = -20, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, /* SMP L21M4PG0 */ @@ -205,6 +210,7 @@ const struct board_batt_params board_battery_info[] = { .charging_max_c = 60, .discharging_min_c = -20, .discharging_max_c = 60, + .vendor_param_start = 0x70, }, }, }; diff --git a/board/homestar/board.c b/board/homestar/board.c index 22f940eec2..47ac34af2c 100644 --- a/board/homestar/board.c +++ b/board/homestar/board.c @@ -674,25 +674,3 @@ uint16_t tcpc_get_alert_status(void) return status; } - -int battery_get_vendor_param(uint32_t param, uint32_t *value) -{ - int rv; - uint8_t data[16] = {}; - - /* only allow reading 0x70~0x7F, 16 byte data */ - if (param < 0x70 || param >= 0x80) - return EC_ERROR_ACCESS_DENIED; - - rv = sb_read_string(0x70, data, sizeof(data)); - if (rv) - return rv; - - *value = data[param - 0x70]; - return EC_SUCCESS; -} - -int battery_set_vendor_param(uint32_t param, uint32_t value) -{ - return EC_ERROR_UNIMPLEMENTED; -} -- cgit v1.2.1