From 511a9f31e84863270ce66c1373dc10797687ba26 Mon Sep 17 00:00:00 2001 From: Bernard Shyu Date: Fri, 5 Dec 2014 13:30:25 +0800 Subject: usb_pd: protocol field extraction error for RDO The RDO fields extraction for op_ma & max_ma are reversed in pd_check_requested_voltage() BUG=none BRANCH=none TEST=make buildall Change-Id: Ifa55b94f43c848b383dc1ab59c857612238e8a63 Reviewed-on: https://chromium-review.googlesource.com/233371 Reviewed-by: Alec Berg Commit-Queue: Bernard Shyu Tested-by: Bernard Shyu --- board/host/usb_pd_policy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/host/usb_pd_policy.c') diff --git a/board/host/usb_pd_policy.c b/board/host/usb_pd_policy.c index 423add3543..7b7a931d86 100644 --- a/board/host/usb_pd_policy.c +++ b/board/host/usb_pd_policy.c @@ -99,8 +99,8 @@ void pd_set_max_voltage(unsigned mv) int pd_check_requested_voltage(uint32_t rdo) { - int op_ma = rdo & 0x3FF; - int max_ma = (rdo >> 10) & 0x3FF; + int max_ma = rdo & 0x3FF; + int op_ma = (rdo >> 10) & 0x3FF; int idx = rdo >> 28; uint32_t pdo; uint32_t pdo_ma; -- cgit v1.2.1