From bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 Mon Sep 17 00:00:00 2001 From: Gwendal Grignou Date: Mon, 11 Mar 2019 15:57:52 -0700 Subject: common: replace 1 << digits, with BIT(digits) Requested for linux integration, use BIT instead of 1 << First step replace bit operation with operand containing only digits. Fix an error in motion_lid try to set bit 31 of a signed integer. BUG=None BRANCH=None TEST=compile Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29 Signed-off-by: Gwendal Grignou Reviewed-on: https://chromium-review.googlesource.com/1518659 Reviewed-by: Daisuke Nojiri --- board/mchpevb1/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/mchpevb1') diff --git a/board/mchpevb1/board.c b/board/mchpevb1/board.c index eeeb557b96..79226d7d71 100644 --- a/board/mchpevb1/board.c +++ b/board/mchpevb1/board.c @@ -880,10 +880,10 @@ static void ds1624_update(void) DS1624_READ_TEMP16, &temp); d = (temp & 0x7FFF) >> 8; - if ((uint32_t)temp & (1 << 7)) + if ((uint32_t)temp & BIT(7)) d++; - if ((uint32_t)temp & (1 << 15)) + if ((uint32_t)temp & BIT(15)) d |= (1u << 31); ds1624_temp = (int32_t)d; -- cgit v1.2.1