From ac77140b7f4f42075d2377fc9d956a636b05aacf Mon Sep 17 00:00:00 2001 From: Gwendal Grignou Date: Mon, 11 Mar 2019 16:07:55 -0700 Subject: common: bit change 1 << constants with BIT(constants) Mechanical replacement of bit operation where operand is a constant. More bit operation exist, but prone to errors. Reveal a bug in npcx: chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow] BUG=None BRANCH=None TEST=None Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0 Signed-off-by: Gwendal Grignou Reviewed-on: https://chromium-review.googlesource.com/1518660 Reviewed-by: Daisuke Nojiri --- board/nami/board.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'board/nami/board.h') diff --git a/board/nami/board.h b/board/nami/board.h index 45e58d49bc..27f8358a99 100644 --- a/board/nami/board.h +++ b/board/nami/board.h @@ -327,7 +327,7 @@ void board_reset_pd_mcu(void); void board_set_tcpc_power_mode(int port, int mode); /* Sensors without hardware FIFO are in forced mode */ -#define CONFIG_ACCEL_FORCE_MODE_MASK ((1 << LID_ACCEL) | (1 << LID_ALS)) +#define CONFIG_ACCEL_FORCE_MODE_MASK (BIT(LID_ACCEL) | BIT(LID_ALS)) /* These should be referenced only after HOOK_INIT:HOOK_PRIO_INIT_I2C+1. */ extern uint16_t board_version; -- cgit v1.2.1