From 3a56be1e353ac4302d2234b7e1f6f516d68c41db Mon Sep 17 00:00:00 2001 From: michael_chen Date: Mon, 3 Sep 2018 11:26:54 +0800 Subject: rammus: Fix PD port 0 reset control behavior Because the GPIO USB_PD_RST_C0_L is high active. When USB_PD_RST_C0_L is high, the PD port 0 i2c communication will fail. BUG=None BRANCH=ToT TEST=Manual. Using consol command "i2cxfer r16 0 0x52 0x00" to read TCPC port 0 VID is ok. Change-Id: I998669f85770672478a4c9131f7b5a767ffd6773 Signed-off-by: michael_chen Reviewed-on: https://chromium-review.googlesource.com/1198905 Commit-Ready: michael chen Tested-by: michael chen Reviewed-by: Zhuohao Lee --- board/rammus/board.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'board/rammus/board.c') diff --git a/board/rammus/board.c b/board/rammus/board.c index 1ae366f68a..c15061670b 100644 --- a/board/rammus/board.c +++ b/board/rammus/board.c @@ -62,7 +62,7 @@ static void tcpc_alert_event(enum gpio_signal signal) { if ((signal == GPIO_USB_C0_PD_INT_ODL) && - !gpio_get_level(GPIO_USB_PD_RST_C0_L)) + gpio_get_level(GPIO_USB_PD_RST_C0)) return; else if ((signal == GPIO_USB_C1_PD_INT_ODL) && !gpio_get_level(GPIO_USB_C1_PD_RST_ODL)) @@ -203,10 +203,10 @@ const int usb_port_enable[CONFIG_USB_PORT_POWER_SMART_PORT_COUNT] = { void board_reset_pd_mcu(void) { /* Assert reset */ - gpio_set_level(GPIO_USB_PD_RST_C0_L, 0); + gpio_set_level(GPIO_USB_PD_RST_C0, 1); gpio_set_level(GPIO_USB_C1_PD_RST_ODL, 0); msleep(1); - gpio_set_level(GPIO_USB_PD_RST_C0_L, 1); + gpio_set_level(GPIO_USB_PD_RST_C0, 0); gpio_set_level(GPIO_USB_C1_PD_RST_ODL, 1); /* After TEST_R release, anx7447/3447 needs 2ms to finish eFuse * loading. @@ -243,7 +243,7 @@ uint16_t tcpc_get_alert_status(void) uint16_t status = 0; if (!gpio_get_level(GPIO_USB_C0_PD_INT_ODL)) { - if (gpio_get_level(GPIO_USB_PD_RST_C0_L)) + if (!gpio_get_level(GPIO_USB_PD_RST_C0)) status |= PD_STATUS_TCPC_ALERT_0; } -- cgit v1.2.1