From a9c7d6b0d73eaf0c48438124b40fc054183701aa Mon Sep 17 00:00:00 2001 From: Vijay Hiremath Date: Tue, 3 Apr 2018 05:44:52 -0700 Subject: Code cleanup: Remove cold reset logic Majority of the chipsets do not have a dedicated GPIO to trigger AP cold reset. Current code either ignores cold reset or does a warm reset instead or have a work around to put AP in S5 and then bring back to S0. In order to avoid the confusion, removed the cold reset logic and only apreset is used hence forth. BUG=b:72426192 BRANCH=none TEST=make buildall -j Manually tested on GLKRVP, apreset EC command can reset AP. Change-Id: Ie32d34f2f327ff1b61b32a4d874250dce024cf35 Signed-off-by: Vijay Hiremath Reviewed-on: https://chromium-review.googlesource.com/991052 Commit-Ready: Vijay P Hiremath Tested-by: Vijay P Hiremath Reviewed-by: Aaron Durbin Reviewed-by: Jett Rink --- board/scarlet/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'board/scarlet') diff --git a/board/scarlet/board.c b/board/scarlet/board.c index 21b2424ea1..fb40b6d0cf 100644 --- a/board/scarlet/board.c +++ b/board/scarlet/board.c @@ -63,7 +63,7 @@ static void overtemp_interrupt(enum gpio_signal signal) static void warm_reset_request_interrupt(enum gpio_signal signal) { CPRINTS("AP wants warm reset"); - chipset_reset(0); + chipset_reset(); } #include "gpio_list.h" -- cgit v1.2.1