From 5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Thu, 25 Feb 2016 10:48:10 -0800 Subject: cleanup: Add warning comment to gpio.inc files With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury --- board/strago/gpio.inc | 3 +++ board/strago/lfw/gpio.inc | 3 +++ 2 files changed, 6 insertions(+) (limited to 'board/strago') diff --git a/board/strago/gpio.inc b/board/strago/gpio.inc index 2ca293e6be..74ea40af80 100644 --- a/board/strago/gpio.inc +++ b/board/strago/gpio.inc @@ -5,6 +5,9 @@ * found in the LICENSE file. */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + GPIO_INT(PD_MCU_INT, PIN(47), GPIO_INT_FALLING | GPIO_INT_DSLEEP, pd_mcu_interrupt) GPIO_INT(USB_C0_VBUS_WAKE_L,PIN(12), GPIO_INT_BOTH, vbus0_evt) GPIO_INT(USB_C0_BC12_INT_L, PIN(155), GPIO_INT_FALLING, usb0_evt) diff --git a/board/strago/lfw/gpio.inc b/board/strago/lfw/gpio.inc index 122aff0cdf..c8199550c4 100644 --- a/board/strago/lfw/gpio.inc +++ b/board/strago/lfw/gpio.inc @@ -7,6 +7,9 @@ * Minimal set of GPIOs needed for LFW loader */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + GPIO(PVT_CS0, PIN(146), GPIO_ODR_HIGH) /* SPI PVT Chip select */ /* Alternate functions GPIO definition */ -- cgit v1.2.1