From 4626177c3b055fdbab6344065d9b335a40ea1c1e Mon Sep 17 00:00:00 2001 From: Anton Staaf Date: Wed, 22 Jul 2015 09:11:46 -0700 Subject: Atomic: Mark the modified uint32_t volatile The atomic_* functions are often used in contexts where the data they will operate on are volatile (due to being shared between tasks or a task and an interrupt handler). Adding volatile here makes using the atomic_* functions a little easier in those cases and removes a cast from the call sites (which could be obscuring a bug, if for instance the variable was modified to be a uint16_t). Signed-off-by: Anton Staaf BRANCH=None BUG=None TEST=make buildall -j Change-Id: I71356eb3cf2c0506df38532eee767c7d78f9240e Reviewed-on: https://chromium-review.googlesource.com/287516 Trybot-Ready: Anton Staaf Tested-by: Anton Staaf Reviewed-by: Vincent Palatin Commit-Queue: Anton Staaf --- board/twinkie/sniffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/twinkie') diff --git a/board/twinkie/sniffer.c b/board/twinkie/sniffer.c index 2842742627..bb2f0834a5 100644 --- a/board/twinkie/sniffer.c +++ b/board/twinkie/sniffer.c @@ -296,9 +296,9 @@ void sniffer_task(void) ep_buf[u][1] = sample_tstamp[d >> 3]; memcpy_to_usbram(((void *)usb_sram_addr(ep_buf[u] + 2)), samples[d >> 4]+off, EP_PAYLOAD_SIZE); - atomic_clear((uint32_t *)&free_usb, 1 << u); + atomic_clear(&free_usb, 1 << u); u = !u; - atomic_clear((uint32_t *)&filled_dma, 1 << d); + atomic_clear(&filled_dma, 1 << d); } led_reset_record(); -- cgit v1.2.1