From 589cd65310dbff8c44fb9e5da5b28d49d4094ce5 Mon Sep 17 00:00:00 2001 From: Aseda Aboagye Date: Fri, 21 Feb 2020 14:39:11 -0800 Subject: dedede: Configure EN_VCCST as input Currently, the EC isn't using EN_VCCST itself, but we are using external logic to set this pin. The pin is initialized to low on the EC which causes a drive fight. This commit changes GPIO_EN_VCCST to an input while we determine whether or not we will use this pin in the EC. BUG=b:149775160 BRANCH=None TEST=`make -j buildall` TEST=Build and flash waddledoo, verify EC cannot set EN_VCCST. Change-Id: Ia9f439d3d049580ac66689fdde11ed75ca044584 Signed-off-by: Aseda Aboagye Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068801 Tested-by: Aseda Aboagye Auto-Submit: Aseda Aboagye Reviewed-by: Diana Z Commit-Queue: Diana Z --- board/waddledee/gpio.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'board/waddledee') diff --git a/board/waddledee/gpio.inc b/board/waddledee/gpio.inc index 24c3fae63b..6d86813bf9 100644 --- a/board/waddledee/gpio.inc +++ b/board/waddledee/gpio.inc @@ -55,7 +55,8 @@ GPIO(EN_PP3300_PEN, PIN(E, 6), GPIO_OUT_LOW) GPIO(EN_PP3300_A, PIN(C, 5), GPIO_OUT_LOW) GPIO(EC_AP_PCH_PWROK_OD, PIN(D, 6), GPIO_ODR_LOW) GPIO(EN_PP5000_U, PIN(K, 5), GPIO_OUT_LOW) -GPIO(EN_VCCST, PIN(D, 4), GPIO_OUT_LOW) +/* TODO(b:149775160) - Modify if needed if we ever use this signal. */ +GPIO(EN_VCCST, PIN(D, 4), GPIO_INPUT) GPIO(EN_VCCIO_EXT, PIN(B, 2), GPIO_OUT_LOW) GPIO(EC_PROCHOT_ODL, PIN(I, 1), GPIO_ODR_HIGH | GPIO_SEL_1P8V) GPIO(EC_AP_VCCST_PWRGD_OD, PIN(E, 5), GPIO_ODR_LOW) -- cgit v1.2.1