From 3973af40f9ca5dd7ba06629b6968b39e912d1c40 Mon Sep 17 00:00:00 2001 From: dnojiri Date: Wed, 4 Dec 2019 14:52:18 -0800 Subject: Define board_override_features_flags APIs as overridable Currently board_override_features_flags0/1 are enabled by CONFIG_EC_FEATURE_BOARD_OVERRIDE. This patch defines the callbacks as overridable. It will allow us to remove CONFIG_EC_FEATURE_BOARD_OVERRIDE and the redundancy it incurs. Signed-off-by: dnojiri BUG=none BRANCH=none TEST=buildall Change-Id: I0c2870b746879b272ada35b9615b611627a9f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1951810 Reviewed-by: Jett Rink Commit-Queue: Daisuke Nojiri Tested-by: Daisuke Nojiri Auto-Submit: Daisuke Nojiri --- board/bloog/board.c | 7 +------ board/bloog/board.h | 2 -- board/bobba/board.c | 7 +------ board/bobba/board.h | 2 -- board/coral/board.c | 7 +------ board/coral/board.h | 1 - board/dratini/board.c | 7 +------ board/dratini/board.h | 1 - board/garg/board.c | 7 +------ board/garg/board.h | 2 -- board/jinlon/board.c | 7 +------ board/jinlon/board.h | 1 - board/kindred/board.c | 7 +------ board/kindred/board.h | 2 -- board/meep/board.c | 7 +------ board/meep/board.h | 2 -- 16 files changed, 8 insertions(+), 61 deletions(-) (limited to 'board') diff --git a/board/bloog/board.c b/board/bloog/board.c index e15bcda472..d68f3b54d5 100644 --- a/board/bloog/board.c +++ b/board/bloog/board.c @@ -314,7 +314,7 @@ void board_overcurrent_event(int port, int is_overcurrented) gpio_set_level(GPIO_USB_C_OC, !is_overcurrented); } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { /* * Remove keyboard backlight feature for devices that don't support it. @@ -325,8 +325,3 @@ uint32_t board_override_feature_flags0(uint32_t flags0) else return flags0; } - -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} diff --git a/board/bloog/board.h b/board/bloog/board.h index 55f5f4fff8..c472543589 100644 --- a/board/bloog/board.h +++ b/board/bloog/board.h @@ -24,8 +24,6 @@ #undef CONFIG_LED_ONOFF_STATES #define CONFIG_LED_COMMON -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE - /* Sensors */ #define CONFIG_ACCEL_KX022 /* Lid accel */ #define CONFIG_ACCELGYRO_LSM6DSM /* Base accel */ diff --git a/board/bobba/board.c b/board/bobba/board.c index 9bbedbcb07..d437e167d3 100644 --- a/board/bobba/board.c +++ b/board/bobba/board.c @@ -352,7 +352,7 @@ static void cbi_init(void) } DECLARE_HOOK(HOOK_INIT, cbi_init, HOOK_PRIO_INIT_I2C + 1); -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { /* * Remove keyboard backlight feature for devices that don't support it. @@ -363,11 +363,6 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} - void board_hibernate_late(void) { int i; diff --git a/board/bobba/board.h b/board/bobba/board.h index 403242587f..9e3bd94e88 100644 --- a/board/bobba/board.h +++ b/board/bobba/board.h @@ -22,8 +22,6 @@ #define CONFIG_LED_COMMON -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE - /* Sensors */ #define CONFIG_ACCEL_KX022 /* Lid accel */ #define CONFIG_ACCELGYRO_BMI160 /* Base accel */ diff --git a/board/coral/board.c b/board/coral/board.c index 5e359c4051..1263ada209 100644 --- a/board/coral/board.c +++ b/board/coral/board.c @@ -1001,7 +1001,7 @@ struct keyboard_scan_config keyscan_config = { }, }; -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { uint32_t sku = system_get_sku_id(); @@ -1019,8 +1019,3 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return flags0; } - -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} diff --git a/board/coral/board.h b/board/coral/board.h index a4d4f393b4..df380f22b9 100644 --- a/board/coral/board.h +++ b/board/coral/board.h @@ -150,7 +150,6 @@ #define CONFIG_WLAN_POWER_ACTIVE_LOW #define WIRELESS_GPIO_WLAN_POWER GPIO_WIRELESS_GPIO_WLAN_POWER #define CONFIG_PWR_STATE_DISCHARGE_FULL -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE /* * During shutdown sequence TPS65094x PMIC turns off the sensor rails diff --git a/board/dratini/board.c b/board/dratini/board.c index 4a1ff9a6e1..d8c673e2e8 100644 --- a/board/dratini/board.c +++ b/board/dratini/board.c @@ -428,7 +428,7 @@ bool board_has_kb_backlight(void) return sku_id == 2 || sku_id == 3 || sku_id == 22 || sku_id == 255; } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { if (board_has_kb_backlight()) return flags0; @@ -436,11 +436,6 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} - #ifdef CONFIG_KEYBOARD_FACTORY_TEST /* * Map keyboard connector pins to EC GPIO pins for factory test. diff --git a/board/dratini/board.h b/board/dratini/board.h index bdf50e7a2c..a16165f6d9 100644 --- a/board/dratini/board.h +++ b/board/dratini/board.h @@ -11,7 +11,6 @@ /* Baseboard features */ #include "baseboard.h" -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE #define CONFIG_POWER_BUTTON #define CONFIG_KEYBOARD_BOARD_CONFIG #define CONFIG_KEYBOARD_PROTOCOL_8042 diff --git a/board/garg/board.c b/board/garg/board.c index 6d740e6650..180b20daac 100644 --- a/board/garg/board.c +++ b/board/garg/board.c @@ -248,7 +248,7 @@ static void cbi_init(void) } DECLARE_HOOK(HOOK_INIT, cbi_init, HOOK_PRIO_INIT_I2C + 1); -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { /* * Remove keyboard backlight feature for devices that don't support it. @@ -259,11 +259,6 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} - void board_hibernate_late(void) { int i; diff --git a/board/garg/board.h b/board/garg/board.h index 218f794b0d..79871f0af6 100644 --- a/board/garg/board.h +++ b/board/garg/board.h @@ -22,8 +22,6 @@ #define CONFIG_LED_COMMON -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE - /* Sensors */ #define CONFIG_ACCEL_KX022 /* Lid accel */ #define CONFIG_ACCELGYRO_BMI160 /* Base accel */ diff --git a/board/jinlon/board.c b/board/jinlon/board.c index b735dfd554..797900ab1e 100644 --- a/board/jinlon/board.c +++ b/board/jinlon/board.c @@ -443,7 +443,7 @@ bool board_has_kb_backlight(void) return sku_id == 2 || sku_id == 3 || sku_id == 22 || sku_id == 255; } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { if (board_has_kb_backlight()) return flags0; @@ -451,11 +451,6 @@ uint32_t board_override_feature_flags0(uint32_t flags0) return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} - #ifdef CONFIG_KEYBOARD_FACTORY_TEST /* * Map keyboard connector pins to EC GPIO pins for factory test. diff --git a/board/jinlon/board.h b/board/jinlon/board.h index 9f831006ad..db87e9e952 100644 --- a/board/jinlon/board.h +++ b/board/jinlon/board.h @@ -11,7 +11,6 @@ /* Baseboard features */ #include "baseboard.h" -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE #define CONFIG_POWER_BUTTON #define CONFIG_KEYBOARD_BOARD_CONFIG #define CONFIG_KEYBOARD_PROTOCOL_8042 diff --git a/board/kindred/board.c b/board/kindred/board.c index 14244d9400..d0e52ae070 100644 --- a/board/kindred/board.c +++ b/board/kindred/board.c @@ -470,15 +470,10 @@ bool board_has_kb_backlight(void) return (sku_id >= 1) && (sku_id <= 4); } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { if (board_has_kb_backlight()) return flags0; else return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } - -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} diff --git a/board/kindred/board.h b/board/kindred/board.h index 2c4875a8de..93406c245f 100644 --- a/board/kindred/board.h +++ b/board/kindred/board.h @@ -22,8 +22,6 @@ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE - /* Keyboard features */ #define CONFIG_PWM #define CONFIG_PWM_KBLIGHT diff --git a/board/meep/board.c b/board/meep/board.c index d9b80d36d9..75dfb069c3 100644 --- a/board/meep/board.c +++ b/board/meep/board.c @@ -312,7 +312,7 @@ void board_overcurrent_event(int port, int is_overcurrented) gpio_set_level(GPIO_USB_C_OC, !is_overcurrented); } -uint32_t board_override_feature_flags0(uint32_t flags0) +__override uint32_t board_override_feature_flags0(uint32_t flags0) { /* * We always compile in backlight support for Meep/Dorp, but only some @@ -326,8 +326,3 @@ uint32_t board_override_feature_flags0(uint32_t flags0) /* Report that there is no keyboard backlight */ return (flags0 &= ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); } - -uint32_t board_override_feature_flags1(uint32_t flags1) -{ - return flags1; -} diff --git a/board/meep/board.h b/board/meep/board.h index 9cf6b2845f..4ea92674c7 100644 --- a/board/meep/board.h +++ b/board/meep/board.h @@ -24,8 +24,6 @@ #define CONFIG_LED_COMMON #define CONFIG_LED_POWER_LED -#define CONFIG_EC_FEATURE_BOARD_OVERRIDE - /* Sensors */ #define CONFIG_ACCEL_KX022 /* Lid accel */ #define CONFIG_ACCELGYRO_LSM6DSM /* Base accel */ -- cgit v1.2.1