From d98339ecc037bcd4c6a0675058e56ea059a69710 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Tue, 25 Feb 2020 16:29:39 -0700 Subject: chip/npcx/lpc: Don't enable Output Buffer Empty by default OBE is enabled by lpc_keyboard_put_char and lpc_mouse_put_char and the disabled by lpc_kbc_obe_interrupt. No reason to enable the interrupt on initialization. BUG=b:145575366 BRANCH=none TEST=Verified OBE interrupt still fires. Change-Id: Iba3f97b2bf4a6c5f09833f808c52901bd8406b4f Signed-off-by: Raul E Rangel Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2073282 Reviewed-by: Edward Hill --- chip/npcx/lpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chip') diff --git a/chip/npcx/lpc.c b/chip/npcx/lpc.c index 672e1154a5..1bcb5571b1 100644 --- a/chip/npcx/lpc.c +++ b/chip/npcx/lpc.c @@ -793,12 +793,12 @@ static void lpc_init(void) /* * Init KBC * Clear OBF status flag, - * IBF(K&M) INT enable, OBE(K&M) empty INT enable , + * IBF(K&M) INT enable, * OBF Mouse Full INT enable and OBF KB Full INT enable */ #ifdef HAS_TASK_KEYPROTO lpc_keyboard_clear_buffer(); - NPCX_HICTRL = 0x0F; + NPCX_HICTRL = 0x0B; #endif /* -- cgit v1.2.1