From bb15561db56728b83ee7fe35e534da7577a7729d Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Mon, 22 Aug 2016 17:55:12 -0700 Subject: cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args Since pretty much always, we've declared console commands to take a "longhelp" argument with detailed explanations of what the command does. But since almost as long, we've never actually used that argument for anything - we just silently throw it away in the macro. There's only one command (usbchargemode) that even thinks it defines that argument. We're never going to use this, let's just get rid of it. BUG=none BRANCH=none CQ-DEPEND=CL:*279060 CQ-DEPEND=CL:*279158 CQ-DEPEND=CL:*279037 TEST=make buildall; tested on Cr50 hardware Everything builds. Since we never used this arg anyway, there had better not be any difference in the result. Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/374163 Reviewed-by: Myles Watson Reviewed-by: Randall Spangler --- common/fan.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'common/fan.c') diff --git a/common/fan.c b/common/fan.c index ae6a9fea98..6f4425bdc9 100644 --- a/common/fan.c +++ b/common/fan.c @@ -132,8 +132,7 @@ static int cc_fanauto(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(fanauto, cc_fanauto, "{fan}", - "Enable thermal fan control", - NULL); + "Enable thermal fan control"); /* Return 0 for off, 1 for on, -1 for unknown */ static int is_powered(int fan) @@ -188,8 +187,7 @@ static int cc_faninfo(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(faninfo, cc_faninfo, NULL, - "Print fan info", - NULL); + "Print fan info"); static int cc_fanset(int argc, char **argv) { @@ -241,8 +239,7 @@ static int cc_fanset(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(fanset, cc_fanset, "{fan} (rpm | pct%)", - "Set fan speed", - NULL); + "Set fan speed"); static int cc_fanduty(int argc, char **argv) { @@ -276,8 +273,7 @@ static int cc_fanduty(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(fanduty, cc_fanduty, "{fan} percent", - "Set fan duty cycle", - NULL); + "Set fan duty cycle"); /*****************************************************************************/ /* DPTF interface functions */ -- cgit v1.2.1