From c6dfa7e03b4c672e1031b4af9230b9da77e50f1a Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Thu, 1 Aug 2013 09:55:58 -0700 Subject: Host commands don't set the response pointer Remove support for allowing host command handlers to set the response pointer. This is just one more thing that can break (and did, on SPI protocol V2). No commands other than the trivial read-memory-map command in host_command.c and flash read made use of this capability, and the savings in performance was negligible. BUG=chrome-os-partner:21576 BRANCH=none TEST=boot pit; still boots Change-Id: I0a9bcf57dbea7155318fc389d7b47d3742a1a00a Signed-off-by: Randall Spangler Reviewed-on: https://gerrit.chromium.org/gerrit/64236 --- common/test_util.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'common/test_util.c') diff --git a/common/test_util.c b/common/test_util.c index 10e718399f..c133ac9d24 100644 --- a/common/test_util.c +++ b/common/test_util.c @@ -70,7 +70,6 @@ int test_send_host_command(int command, int version, const void *params, int params_size, void *resp, int resp_size) { struct host_cmd_handler_args args; - int rv; args.version = version; args.command = command; @@ -80,12 +79,7 @@ int test_send_host_command(int command, int version, const void *params, args.response_max = resp_size; args.response_size = 0; - rv = host_command_process(&args); - - if (args.response != resp) - memcpy(resp, args.response, args.response_size); - - return rv; + return host_command_process(&args); } #endif /* TASK_HAS_HOSTCMD */ -- cgit v1.2.1