From 81832b5d2e00c5d606d78f8cbd6b4074af75c0c0 Mon Sep 17 00:00:00 2001 From: Keith Short Date: Wed, 2 Sep 2020 15:28:55 -0600 Subject: tcpmv2: Fix SOP' DiscoverIdent retries. The PE DRP state machine was sending retries of SOP' DiscoverIdent without any delay. This sets the delay between SOP' DiscoverIdent to tDiscoverIdentity (45 ms). The EC uses this delay regardless of the explicitly contract state. BUG=b:166650426 BRANCH=none TEST=make buildall TEST=Connect SNK device without emarker cable. Observe retries are spaced by at least 45ms. TEST=Connect emarker cable and verify cable identity is discovered. Signed-off-by: Keith Short Change-Id: I05134052fe3576e1dd94d8aa0963a67dce080027 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2391822 Reviewed-by: Diana Z Commit-Queue: Diana Z --- common/usbc/usb_pe_drp_sm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common') diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 43c4817e7b..83660bcc0a 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -4766,7 +4766,7 @@ static void pe_vdm_identity_request_cbl_exit(int port) * desired here */ if (pd_get_identity_discovery(port, pe[port].tx_type) == PD_DISC_NEEDED - && pe[port].discover_identity_timer > get_time().val) + && pe[port].discover_identity_timer < get_time().val) pe[port].discover_identity_timer = get_time().val + PD_T_DISCOVER_IDENTITY; -- cgit v1.2.1