From 9cfcd92ad0e417d08791ec8446eb9a9524ef72a2 Mon Sep 17 00:00:00 2001 From: Andrey Pronin Date: Fri, 17 Mar 2023 22:28:15 -0700 Subject: new_nvmem: fix update_pcr Before this fix, update_pcr was inserting an extra byte at the start of the updated value. BUG=b:273331256 TEST=see BUG Change-Id: Idb648ff7f999c48f93bd7dfe9a207ecd48fa53d5 Signed-off-by: Andrey Pronin Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4351200 Reviewed-by: Vadim Sukhomlinov Commit-Queue: Andrey Pronin Tested-by: Andrey Pronin --- common/new_nvmem.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'common') diff --git a/common/new_nvmem.c b/common/new_nvmem.c index 8e496fe9a5..2d6a801512 100644 --- a/common/new_nvmem.c +++ b/common/new_nvmem.c @@ -2425,15 +2425,7 @@ static enum ec_error_list update_pcr(const struct access_tracker *at, struct nn_container *ch, uint8_t index, uint8_t *cached) { - uint8_t preserved; - - cached--; - preserved = cached[0]; - cached[0] = index; - update_object(at, ch, cached, ch->size); - cached[0] = preserved; - - return EC_SUCCESS; + return update_object(at, ch, cached, ch->size); } static enum ec_error_list save_pcr(struct nn_container *ch, -- cgit v1.2.1