From bb15561db56728b83ee7fe35e534da7577a7729d Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Mon, 22 Aug 2016 17:55:12 -0700 Subject: cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args Since pretty much always, we've declared console commands to take a "longhelp" argument with detailed explanations of what the command does. But since almost as long, we've never actually used that argument for anything - we just silently throw it away in the macro. There's only one command (usbchargemode) that even thinks it defines that argument. We're never going to use this, let's just get rid of it. BUG=none BRANCH=none CQ-DEPEND=CL:*279060 CQ-DEPEND=CL:*279158 CQ-DEPEND=CL:*279037 TEST=make buildall; tested on Cr50 hardware Everything builds. Since we never used this arg anyway, there had better not be any difference in the result. Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/374163 Reviewed-by: Myles Watson Reviewed-by: Randall Spangler --- driver/battery/bq27621_g1.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) (limited to 'driver/battery/bq27621_g1.c') diff --git a/driver/battery/bq27621_g1.c b/driver/battery/bq27621_g1.c index e08e700522..c55d452c87 100644 --- a/driver/battery/bq27621_g1.c +++ b/driver/battery/bq27621_g1.c @@ -576,8 +576,7 @@ static int command_fgunseal(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgunseal, command_fgunseal, "", - "Unseal the fg", - NULL); + "Unseal the fg"); static int command_fgseal(int argc, char **argv) { @@ -593,8 +592,7 @@ static int command_fgseal(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgseal, command_fgseal, "", - "Seal the fg", - NULL); + "Seal the fg"); static int command_fginit(int argc, char **argv) { @@ -629,8 +627,7 @@ static int command_fginit(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fginit, command_fginit, "[force]", - "Initialize the fg", - NULL); + "Initialize the fg"); static int command_fgprobe(int argc, char **argv) { @@ -646,8 +643,7 @@ static int command_fgprobe(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgprobe, command_fgprobe, "", - "Probe the fg", - NULL); + "Probe the fg"); static int command_fgrd(int argc, char **argv) { @@ -681,8 +677,7 @@ static int command_fgrd(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgrd, command_fgrd, "cmd len", - "Read _len_ words from the fg", - NULL); + "Read _len_ words from the fg"); static int command_fgcmd(int argc, char **argv) { @@ -718,8 +713,7 @@ static int command_fgcmd(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgcmd, command_fgcmd, "cmd data [byte]", - "Send a cmd to the fg", - NULL); + "Send a cmd to the fg"); static int command_fgcmdrd(int argc, char **argv) { @@ -747,8 +741,7 @@ static int command_fgcmdrd(int argc, char **argv) DECLARE_CONSOLE_COMMAND(fgcmdrd, command_fgcmdrd, "cmd data", - "Send a 2-byte cmd to the fg, read back the 2-byte result", - NULL); + "Send a 2-byte cmd to the fg, read back the 2-byte result"); #endif /* CONFIG_CMD_BATDEBUG */ -- cgit v1.2.1