From 1746c5b0d9b369bf8d11600ef822ae65f84c9fc1 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Sat, 28 Feb 2015 13:12:54 -0800 Subject: pi3usb9281: Always set reserved control bits Bits 1 and 3 of the control register are read 1, write 1, but RO firmware may have zero'd these bits. Therefore, always set the bits high, ignoring the read value. TEST=Manual on Samus. Starting from .90 RO, flash new RW and verify BC1.2 charger detection is working. BUG=chrome-os-partner:37241 BRANCH=Samus Change-Id: I2f71718f74e50fe9b664dbe3da1578ee4c995136 Signed-off-by: Shawn Nematbakhsh Reviewed-on: https://chromium-review.googlesource.com/254880 Reviewed-by: Alec Berg --- driver/pi3usb9281.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'driver/pi3usb9281.h') diff --git a/driver/pi3usb9281.h b/driver/pi3usb9281.h index 49a078ee6f..56b126c1e3 100644 --- a/driver/pi3usb9281.h +++ b/driver/pi3usb9281.h @@ -26,6 +26,8 @@ #define PI3USB9281_CTRL_SWITCH_AUTO (1 << 4) /* Bits 5 thru 7 are read X, write 0 */ #define PI3USB9281_CTRL_MASK 0x1f +/* Bits 1 and 3 are read 1, write 1 */ +#define PI3USB9281_CTRL_RSVD_1 0x0a #define PI3USB9281_PIN_MANUAL_VBUS (3 << 0) #define PI3USB9281_PIN_MANUAL_DP (1 << 2) -- cgit v1.2.1