From bbd967de266e4c615d3e34ed8ae5425f175bf7e0 Mon Sep 17 00:00:00 2001 From: Vijay Hiremath Date: Fri, 18 Jun 2021 11:25:30 -0700 Subject: bb_retimer: cleanup: Change the power handler func name & params Changed the power handler function name from bb_retimer_power_handle() to bb_retimer_power_enable() and on_off param to enable. BUG=none BRANCH=none TEST=make buildall -j Change-Id: Ifad4c71a5d76b4841ea369a991160e221c051ec5 Signed-off-by: Vijay Hiremath Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2973375 Reviewed-by: Abe Levkoy --- driver/retimer/bb_retimer.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'driver/retimer/bb_retimer.c') diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index 2f98b4b185..94162a43fa 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -123,13 +123,13 @@ static int bb_retimer_write(const struct usb_mux *me, return rv; } -__overridable int bb_retimer_power_handle(const struct usb_mux *me, int on_off) +__overridable int bb_retimer_power_enable(const struct usb_mux *me, bool enable) { const struct bb_usb_control *control = &bb_controls[me->usb_port]; /* handle retimer's power domain */ - if (on_off) { + if (enable) { gpio_set_level(control->usb_ls_en_gpio, 1); /* * Tpw, minimum time from VCC to RESET_N de-assertion is 100us. @@ -470,8 +470,7 @@ static int retimer_set_state(const struct usb_mux *me, mux_state_t mux_state) static int retimer_low_power_mode(const struct usb_mux *me) { - bb_retimer_power_handle(me, 0); - return EC_SUCCESS; + return bb_retimer_power_enable(me, false); } static bool is_retimer_fw_update_capable(void) @@ -487,11 +486,11 @@ static int retimer_init(const struct usb_mux *me) /* Burnside Bridge is powered by main AP rail */ if (chipset_in_or_transitioning_to_state(CHIPSET_STATE_ANY_OFF)) { /* Ensure reset is asserted while chip is not powered */ - bb_retimer_power_handle(me, 0); + bb_retimer_power_enable(me, false); return EC_ERROR_NOT_POWERED; } - rv = bb_retimer_power_handle(me, 1); + rv = bb_retimer_power_enable(me, true); if (rv != EC_SUCCESS) return rv; -- cgit v1.2.1