From f5dc7104a1d034b1ea776691e34aaee1e90775b2 Mon Sep 17 00:00:00 2001 From: madhusudanarao amara Date: Wed, 15 Sep 2021 19:02:05 +0530 Subject: Revert "DP/TBT/USB4: Retimer WA resolved Brya TBT lane bonding issue in AP mode" This reverts commit f0985f8a11585f6a704aa94a8354bd5b934619ac. Reason for revert: Issue is resolved after setting the Force BB Retimer GPIO (GPP_E4) to 0. It is a coreboot change. BUG=b:195375738 BRANCH=None TEST=TBT enumerated no lane bonding issue is observed with above coreboot code change with reverted EC WA. Signed-off-by: madhusudanarao amara Change-Id: I09a8a53aec9ba3757189a091606922bc7a133ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3162936 Reviewed-by: Deepti Deshatty Reviewed-by: caveh jalali Reviewed-by: Vijay Hiremath Commit-Queue: caveh jalali --- driver/retimer/bb_retimer.c | 20 -------------------- 1 file changed, 20 deletions(-) (limited to 'driver/retimer/bb_retimer.c') diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index 2e2e15f44f..bf3da60b32 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -364,18 +364,6 @@ static void retimer_set_state_ufp(int port, mux_state_t mux_state, } } -/** - * Driver interface function: reset retimer - */ -__overridable int bb_retimer_reset(const struct usb_mux *me) -{ - /* - * TODO(b/193402306, b/195375738): Remove this once transition to - * QS Silicon is complete - */ - return EC_SUCCESS; -} - /** * Driver interface functions */ @@ -479,14 +467,6 @@ static int retimer_set_state(const struct usb_mux *me, mux_state_t mux_state, else retimer_set_state_ufp(port, mux_state, &set_retimer_con); - /* - * In AP Mode DP exit to TBT entry is causing TBT lane bonding issue - * Issue is not seen by calling the retimer reset as WA at the time of - * disconnect mode configuration - */ - if (mux_state == USB_PD_MUX_NONE) - bb_retimer_reset(me); - /* Writing the register4 */ return bb_retimer_write(me, BB_RETIMER_REG_CONNECTION_STATE, set_retimer_con); -- cgit v1.2.1