From c8d7408e9f4d2d29573b0c70811d31092ad6aa1d Mon Sep 17 00:00:00 2001 From: Ayushee Shah Date: Wed, 24 Feb 2021 12:18:58 -0800 Subject: BB retimer: Do not need B16 to be set for USB4 mode Retimer bit16 is don't care for USB4 mode, so do not update it BUG=None BRANCH=None TEST=Tested on voxel, USB4 enumerates fine. Signed-off-by: Ayushee Shah Change-Id: I4e161542cd6eeda5b595cf3c071aafe71b8754cb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2719197 Reviewed-by: Vijay P Hiremath Reviewed-by: Keith Short --- driver/retimer/bb_retimer.c | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'driver') diff --git a/driver/retimer/bb_retimer.c b/driver/retimer/bb_retimer.c index 17c75a486d..a8e93949c1 100644 --- a/driver/retimer/bb_retimer.c +++ b/driver/retimer/bb_retimer.c @@ -158,7 +158,6 @@ static void retimer_set_state_dfp(int port, mux_state_t mux_state, .raw_value = pd_get_tbt_mode_vdo(port, TCPC_TX_SOP_PRIME) }; union tbt_mode_resp_device dev_resp; enum idh_ptype cable_type = get_usb_pd_cable_type(port); - struct pd_discovery *disc; /* * Bit 2: RE_TIMER_DRIVER @@ -263,17 +262,6 @@ static void retimer_set_state_dfp(int port, mux_state_t mux_state, *set_retimer_con |= BB_RETIMER_TBT_CABLE_GENERATION( cable_resp.tbt_rounded); } - if (mux_state & USB_PD_MUX_USB4_ENABLED) { - disc = pd_get_am_discovery(port, TCPC_TX_SOP); - - /* - * Bit 16: TBT_CONNECTION - * 0 - Port partner doesn't support TBT3 - * 1 - Port partner supports TBT3 - */ - if (PD_PRODUCT_IS_TBT3(disc->identity.product_t1.raw_value)) - *set_retimer_con |= BB_RETIMER_TBT_CONNECTION; - } } static void retimer_set_state_ufp(int port, mux_state_t mux_state, -- cgit v1.2.1