From 4c1de11ed14cff24335b370f022bee598cd20ee8 Mon Sep 17 00:00:00 2001 From: Yilun Lin Date: Sat, 8 Sep 2018 00:08:36 +0800 Subject: type: Rename vec3_t to floatv3_t. Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I8cac6a7c0abe3d462326291b76b1ed44ce6c9a9c Signed-off-by: Yilun Lin Reviewed-on: https://chromium-review.googlesource.com/1215443 Commit-Ready: Yilun Lin Tested-by: Yilun Lin Reviewed-by: Nicolas Boichat --- include/vec3.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'include/vec3.h') diff --git a/include/vec3.h b/include/vec3.h index 68ec1a5c72..367956b2a1 100644 --- a/include/vec3.h +++ b/include/vec3.h @@ -7,11 +7,11 @@ #ifndef __CROS_EC_VEC_3_H #define __CROS_EC_VEC_3_H -typedef float vec3_t[3]; +typedef float floatv3_t[3]; -void vec3_scalar_mul(vec3_t v, float c); -float vec3_dot(const vec3_t v, const vec3_t w); -float vec3_norm_squared(const vec3_t v); -float vec3_norm(const vec3_t v); +void floatv3_scalar_mul(floatv3_t v, float c); +float floatv3_dot(const floatv3_t v, const floatv3_t w); +float floatv3_norm_squared(const floatv3_t v); +float floatv3_norm(const floatv3_t v); #endif /* __CROS_EC_VEC_3_H */ -- cgit v1.2.1