From 096f04f03ade187dabb277363e66aa5fe5326881 Mon Sep 17 00:00:00 2001 From: Nicolas Boichat Date: Thu, 30 Aug 2018 15:59:14 +0800 Subject: power/mt8183: Keep PMIC_WATCHDOG_L low in S5/S3 Instead of pulsing the watchdog to PMIC, keep it low in S5/G3. This avoids leaking power from EC to PMIC in S5/G3, when the PMIC is off. BRANCH=none BUG=b:113559677 TEST=In G3, pp1800_ec_mw power consumption drops from ~23mW to <1mW. Change-Id: I37bc8e5e6954834e1ae2bc1206919f342273b888 Signed-off-by: Nicolas Boichat Reviewed-on: https://chromium-review.googlesource.com/1195300 Reviewed-by: Yilun Lin --- power/mt8183.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'power') diff --git a/power/mt8183.c b/power/mt8183.c index 4522efcd02..b3416c0a70 100644 --- a/power/mt8183.c +++ b/power/mt8183.c @@ -63,6 +63,8 @@ BUILD_ASSERT(GPIO_COUNT < 256); */ static const struct power_seq_op s5s3_power_seq[] = { + /* Release PMIC watchdog. */ + { GPIO_PMIC_WATCHDOG_L, 1, 0 }, { GPIO_PP3300_S3_EN, 1, 2 }, { GPIO_PP1800_S3_EN, 1, 2 }, /* Turn on AP. */ @@ -85,9 +87,8 @@ static const struct power_seq_op s3s5_power_seq[] = { { GPIO_AP_SYS_RST_L, 0, 0 }, { GPIO_PP1800_S3_EN, 0, 2 }, { GPIO_PP3300_S3_EN, 0, 2 }, - /* Pulse watchdog to PMIC (there may be a 1.6ms debounce) */ + /* Assert watchdog to PMIC (there may be a 1.6ms debounce) */ { GPIO_PMIC_WATCHDOG_L, 0, 3 }, - { GPIO_PMIC_WATCHDOG_L, 1, 0 }, }; static int forcing_shutdown; -- cgit v1.2.1