From 3da80621017eed8462f1825fe073de5db729d428 Mon Sep 17 00:00:00 2001 From: Aseda Aboagye Date: Tue, 24 Mar 2020 17:35:15 -0700 Subject: icelake: Call hooks around RSMRST when shutting down When we decide to force the chipset to shutdown, we were just simply asserting RSMRST_L which was bypassing the hooks around RSMRST (i.e. - board_has_before_rsmrst() and board_has_after_rsmsrt()). BUG=b:151680590 BRANCH=None TEST=Build and flash waddledoo, boot AP and shutdown, verify that PG_PP1050_ST is no longer asserted. Signed-off-by: Aseda Aboagye Change-Id: I8bc33ff12bf776dab7158bc2efac0637cebdaca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2119590 Tested-by: Aseda Aboagye Auto-Submit: Aseda Aboagye Reviewed-by: Keith Short Commit-Queue: Keith Short --- power/icelake.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'power') diff --git a/power/icelake.c b/power/icelake.c index 2d177dd14f..fe48e22d24 100644 --- a/power/icelake.c +++ b/power/icelake.c @@ -5,6 +5,7 @@ /* Icelake chipset power control module for Chrome EC */ +#include "board_config.h" #include "chipset.h" #include "console.h" #include "gpio.h" @@ -95,7 +96,9 @@ void chipset_force_shutdown(enum chipset_shutdown_reason reason) report_ap_reset(reason); /* Turn off RMSRST_L to meet tPCH12 */ + board_before_rsmrst(0); GPIO_SET_LEVEL(GPIO_PCH_RSMRST_L, 0); + board_after_rsmrst(0); /* Turn off DSW_PWROK to meet tPCH14 */ GPIO_SET_LEVEL(GPIO_PCH_DSW_PWROK, 0); -- cgit v1.2.1