From e77ccb89c1b74a9ba3be47072d35e3e148d2a469 Mon Sep 17 00:00:00 2001 From: Evan Green Date: Tue, 1 Oct 2019 14:07:03 -0700 Subject: Remove uses of %l This change removes uses of %l from the EC side of the EC codebase. This is done because the semantics of %l within printf have changed, and there are concerns that new calls to printf will be cherry-picked into old firmware branches without the printf changes. So, in preparation for disallowing %l in master, remove occurrences of %l. This change was done by manually fixing up anything found under the EC directory with the following regex: %[0-9*.-]*l[^l] Remember that anything on the host machine is fine as-is, since the host printf never changed. BUG=chromium:984041 TEST=make -j buildall BRANCH=None Change-Id: I2a97433ddab5bfb8a6031ca4ff1d3905289444e2 Signed-off-by: Evan Green Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834603 Reviewed-by: Jack Rosenthal --- test/printf.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'test/printf.c') diff --git a/test/printf.c b/test/printf.c index 400f9a4064..c521590440 100644 --- a/test/printf.c +++ b/test/printf.c @@ -174,12 +174,9 @@ test_static int test_vsnprintf_int(void) T(expect_success(" 0.00123", "%9.5d", 123)); T(expect_success(" +0.00123", "%+9.5d", 123)); - T(expect_success("-1", "%ld", (int64_t)-1)); - T(expect_success("4294967295", "%ld", (uint32_t)-1)); - T(expect_success("123", "%u", 123)); T(expect_success("4294967295", "%u", -1)); - T(expect_success("18446744073709551615", "%lu", (uint64_t)-1)); + T(expect_success("18446744073709551615", "%llu", (uint64_t)-1)); T(expect_success("0", "%x", 0)); T(expect_success("0", "%X", 0)); -- cgit v1.2.1