From f962b50c920c4566ec9f40f884b4739b772a329b Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 12 Sep 2019 16:27:14 +0200 Subject: util/ecst: Fix sign issues for file size Since we'll never have to deal with 2GB+ sized images, don't bother with larger data types. Found by Coverity Scan #203948 BUG=none BRANCH=none TEST=none Change-Id: I95cb75d693b94444a87d2100a3f25ddae87a5faa Signed-off-by: Patrick Georgi Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1801207 Reviewed-by: Daisuke Nojiri Tested-by: Patrick Georgi Commit-Queue: Patrick Georgi --- util/ecst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'util/ecst.c') diff --git a/util/ecst.c b/util/ecst.c index 8bfedce488..22f9f6c0e8 100644 --- a/util/ecst.c +++ b/util/ecst.c @@ -33,7 +33,7 @@ unsigned int fw_offset; int is_ptr_merge; unsigned int g_ram_start_address; unsigned int g_ram_size; -unsigned int api_file_size_bytes; +int api_file_size_bytes; int is_mrider15 = FALSE; /* Chips information, RAM start address and RAM size. */ @@ -2289,7 +2289,7 @@ unsigned int calc_api_csum_bin(void) unsigned int i; unsigned int calc_read_bytes; - unsigned int calc_num_of_bytes_to_read; + int calc_num_of_bytes_to_read; unsigned int calc_curr_position; unsigned int calc_fw_checksum_crc = 0; unsigned char g_fw_array[BUFF_SIZE]; -- cgit v1.2.1