From 2e3d89e009584037331a50a07540fa5fcd49e89f Mon Sep 17 00:00:00 2001 From: Dawid Niedzwiecki Date: Thu, 15 Jul 2021 13:51:35 +0200 Subject: zephyr: fix MKBP_HOST_EVENT_WAKEUP_MASK MKBP_HOST_EVENT_WAKEUP_MASK is right-shifted by 1 bit, so adjust defining it in the dts. The bug is impacting the waking up DUT with a host event, e.g. EC_HOST_EVENT_RTC which is used during the firmware_EventLog test. BUG=b:193495066 BRANCH=none TEST=Suspend DUT with powerd_dbus_suspend, and make sure the EC command "hostevent set 0x0000000002000000" wakes up the board. Signed-off-by: Dawid Niedzwiecki Change-Id: I253d0dc36cf216fe50a6473c3640fe906ef565e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3031542 Reviewed-by: Simon Glass --- zephyr/dts/bindings/cros_mkbp_event/ec-mkbp-event.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'zephyr/dts/bindings') diff --git a/zephyr/dts/bindings/cros_mkbp_event/ec-mkbp-event.yaml b/zephyr/dts/bindings/cros_mkbp_event/ec-mkbp-event.yaml index c8f5a0c376..73f0e8fdca 100644 --- a/zephyr/dts/bindings/cros_mkbp_event/ec-mkbp-event.yaml +++ b/zephyr/dts/bindings/cros_mkbp_event/ec-mkbp-event.yaml @@ -14,3 +14,16 @@ properties: description: Define the MKBP or host events that will wake up the application processor from suspend mode. + HOST_EVENT_MASK should be used for ec-mkbp-host-event-wakeup-mask e.g. + ec-mkbp-host-event-wakeup-mask { + compatible = "ec-wake-mask-event"; + wakeup-mask = <( + HOST_EVENT_MASK(HOST_EVENT_LID_OPEN) | + HOST_EVENT_MASK(HOST_EVENT_POWER_BUTTON) | + HOST_EVENT_MASK(HOST_EVENT_AC_CONNECTED) | + HOST_EVENT_MASK(HOST_EVENT_AC_DISCONNECTED) | + HOST_EVENT_MASK(HOST_EVENT_HANG_DETECT) | + HOST_EVENT_MASK(HOST_EVENT_RTC) | + HOST_EVENT_MASK(HOST_EVENT_MODE_CHANGE) | + HOST_EVENT_MASK(HOST_EVENT_DEVICE))>; + }; -- cgit v1.2.1