1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
|
/* Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
/* Console commands to trigger flash host commands */
#include "board.h"
#include "console.h"
#include "ec_commands.h"
#include "flash.h"
#include "gpio.h"
#include "hooks.h"
#include "host_command.h"
#include "system.h"
#include "timer.h"
#include "util.h"
static int error_count;
static int last_write_offset;
static int last_write_size;
static char last_write_data[64];
static int last_erase_offset;
static int last_erase_size;
static int mock_wp = -1;
#define TEST_STATE_CLEAN_UP (1 << 0)
#define TEST_STATE_STEP_2 (1 << 1)
#define TEST_STATE_STEP_3 (1 << 2)
#define TEST_STATE_BOOT_WP_ON (1 << 3)
#define TEST_STATE_PASSED (1 << 4)
#define CLEAN_UP_FLAG_PASSED TEST_STATE_PASSED
#define CLEAN_UP_FLAG_FAILED 0
/*****************************************************************************/
/* Mock functions */
void host_send_response(struct host_cmd_handler_args *args)
{
/* Do nothing */
}
int flash_write(int offset, int size, const char *data)
{
last_write_offset = offset;
last_write_size = size;
memcpy(last_write_data, data, size);
return EC_SUCCESS;
}
int flash_erase(int offset, int size)
{
last_erase_offset = offset;
last_erase_size = size;
return EC_SUCCESS;
}
int gpio_get_level(enum gpio_signal signal)
{
const char *name = gpio_list[signal].name;
if (mock_wp == -1)
mock_wp = !!(system_get_scratchpad() & TEST_STATE_BOOT_WP_ON);
if (strcasecmp(name, "WRITE_PROTECTn") == 0 ||
strcasecmp(name, "WP_L") == 0)
return !mock_wp;
if (strcasecmp(name, "WRITE_PROTECT") == 0 ||
strcasecmp(name, "WP") == 0)
return mock_wp;
/* Signal other than write protect. Just return 0. */
return 0;
}
/*****************************************************************************/
/* Test utilities */
#define RUN_TEST(n) \
do { \
ccprintf("Running %s...", #n); \
cflush(); \
if (n() == EC_SUCCESS) { \
ccputs("OK\n"); \
} else { \
ccputs("Fail\n"); \
error_count++; \
} \
} while (0)
static void begin_verify(void)
{
last_write_offset = -1;
last_write_size = -1;
last_write_data[0] = '\0';
last_erase_offset = -1;
last_erase_size = -1;
}
static int verify_write(int offset, int size, const char *data)
{
int i;
if (offset != last_write_offset || size != last_write_size)
return EC_ERROR_UNKNOWN;
for (i = 0; i < size; ++i)
if (data[i] != last_write_data[i])
return EC_ERROR_UNKNOWN;
return EC_SUCCESS;
}
#define TEST_ASSERT(x) \
do { \
if (!(x)) \
return EC_ERROR_UNKNOWN; \
} while (0)
#define VERIFY_NO_WRITE(off, sz, d) \
do { \
begin_verify(); \
host_command_write(off, sz, d); \
TEST_ASSERT(last_write_offset == -1 && last_write_size == -1); \
} while (0)
#define VERIFY_NO_ERASE(off, sz) \
do { \
begin_verify(); \
host_command_erase(off, sz); \
TEST_ASSERT(last_erase_offset == -1 && last_erase_size == -1); \
} while (0)
#define VERIFY_WRITE(off, sz, d) \
do { \
begin_verify(); \
host_command_write(off, sz, d); \
TEST_ASSERT(verify_write(off, sz, d) == EC_SUCCESS); \
} while (0)
#define VERIFY_ERASE(off, sz) \
do { \
begin_verify(); \
host_command_erase(off, sz); \
TEST_ASSERT(last_erase_offset == off && \
last_erase_size == sz); \
} while (0)
#define SET_WP_FLAGS(m, f) \
TEST_ASSERT(host_command_protect(m, ((f) ? m : 0), \
NULL, NULL, NULL) == EC_RES_SUCCESS)
#define ASSERT_WP_FLAGS(f) \
do { \
uint32_t flags; \
TEST_ASSERT(host_command_protect(0, 0, &flags, NULL, NULL) == \
EC_RES_SUCCESS); \
TEST_ASSERT(flags & (f)); \
} while (0)
#define ASSERT_WP_NO_FLAGS(f) \
do { \
uint32_t flags; \
TEST_ASSERT(host_command_protect(0, 0, &flags, NULL, NULL) == \
EC_RES_SUCCESS); \
TEST_ASSERT((flags & (f)) == 0); \
} while (0)
int host_command_write(int offset, int size, const char *data)
{
struct host_cmd_handler_args args;
struct ec_params_flash_write params;
params.offset = offset;
params.size = size;
memcpy(params.data, data, size);
args.version = 0;
args.command = EC_CMD_FLASH_WRITE;
args.params = ¶ms;
args.params_size = sizeof(params);
args.response = NULL;
args.response_max = 0;
args.response_size = 0;
return host_command_process(&args);
}
int host_command_erase(int offset, int size)
{
struct host_cmd_handler_args args;
struct ec_params_flash_write params;
params.offset = offset;
params.size = size;
args.version = 0;
args.command = EC_CMD_FLASH_ERASE;
args.params = ¶ms;
args.params_size = sizeof(params);
args.response = NULL;
args.response_max = 0;
args.response_size = 0;
return host_command_process(&args);
}
int host_command_protect(uint32_t mask, uint32_t flags,
uint32_t *flags_out, uint32_t *valid_out,
uint32_t *writable_out)
{
struct host_cmd_handler_args args;
struct ec_params_flash_protect params;
struct ec_response_flash_protect *r =
(struct ec_response_flash_protect *)¶ms;
int res;
params.mask = mask;
params.flags = flags;
args.version = 1;
args.command = EC_CMD_FLASH_PROTECT;
args.params = ¶ms;
args.params_size = sizeof(params);
args.response = ¶ms;
args.response_max = EC_HOST_PARAM_SIZE;
args.response_size = 0;
res = host_command_process(&args);
if (res == EC_RES_SUCCESS) {
if (flags_out)
*flags_out = r->flags;
if (valid_out)
*valid_out = r->valid_flags;
if (writable_out)
*writable_out = r->writable_flags;
}
return res;
}
/*****************************************************************************/
/* Tests */
static int test_overwrite_current(void)
{
uint32_t offset, size;
const char *d = "TestData0000000"; /* 16 bytes */
/* Test that we cannot overwrite current image */
if (system_get_image_copy() == SYSTEM_IMAGE_RO) {
offset = CONFIG_FW_RO_OFF;
size = CONFIG_FW_RO_SIZE;
} else {
offset = CONFIG_FW_RW_OFF;
size = CONFIG_FW_RW_SIZE;
}
VERIFY_NO_ERASE(offset, sizeof(d));
VERIFY_NO_ERASE(offset + size - sizeof(d), sizeof(d));
VERIFY_NO_WRITE(offset, sizeof(d), d);
VERIFY_NO_WRITE(offset + size - sizeof(d), sizeof(d), d);
return EC_SUCCESS;
}
static int test_overwrite_other(void)
{
uint32_t offset, size;
const char *d = "TestData0000000"; /* 16 bytes */
/* Test that we can overwrite the other image */
if (system_get_image_copy() == SYSTEM_IMAGE_RW) {
offset = CONFIG_FW_RO_OFF;
size = CONFIG_FW_RO_SIZE;
} else {
offset = CONFIG_FW_RW_OFF;
size = CONFIG_FW_RW_SIZE;
}
VERIFY_ERASE(offset, sizeof(d));
VERIFY_ERASE(offset + size - sizeof(d), sizeof(d));
VERIFY_WRITE(offset, sizeof(d), d);
VERIFY_WRITE(offset + size - sizeof(d), sizeof(d), d);
return EC_SUCCESS;
}
static int test_write_protect(void)
{
/* Test we can control write protect GPIO */
mock_wp = 0;
ASSERT_WP_NO_FLAGS(EC_FLASH_PROTECT_GPIO_ASSERTED);
mock_wp = 1;
ASSERT_WP_FLAGS(EC_FLASH_PROTECT_GPIO_ASSERTED);
/* Test software WP can be disable if nothing is actually protected */
SET_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT, 1);
SET_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT, 0);
ASSERT_WP_NO_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT);
/* Actually protect flash and test software WP cannot be disabled */
SET_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT, 1);
SET_WP_FLAGS(EC_FLASH_PROTECT_ALL_NOW, 1);
SET_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT, 0);
SET_WP_FLAGS(EC_FLASH_PROTECT_ALL_NOW, 0);
ASSERT_WP_FLAGS(EC_FLASH_PROTECT_ALL_NOW | EC_FLASH_PROTECT_RO_AT_BOOT);
/* Check we cannot erase anything */
TEST_ASSERT(flash_physical_erase(CONFIG_SECTION_RO_OFF,
CONFIG_FLASH_ERASE_SIZE) != EC_SUCCESS);
TEST_ASSERT(flash_physical_erase(CONFIG_SECTION_RW_OFF,
CONFIG_FLASH_ERASE_SIZE) != EC_SUCCESS);
return EC_SUCCESS;
}
static int test_boot_write_protect(void)
{
/* Check write protect state persists through reboot */
ASSERT_WP_FLAGS(EC_FLASH_PROTECT_RO_NOW | EC_FLASH_PROTECT_RO_AT_BOOT);
TEST_ASSERT(flash_physical_erase(CONFIG_SECTION_RO_OFF,
CONFIG_FLASH_ERASE_SIZE) != EC_SUCCESS);
return EC_SUCCESS;
}
static int test_boot_no_write_protect(void)
{
/* Check write protect is not enabled if WP GPIO is deasserted */
ASSERT_WP_NO_FLAGS(EC_FLASH_PROTECT_RO_NOW);
ASSERT_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT);
return EC_SUCCESS;
}
static int clean_up(void)
{
system_set_scratchpad(0);
SET_WP_FLAGS(EC_FLASH_PROTECT_RO_AT_BOOT, 0);
return EC_SUCCESS;
}
static void reboot_to_clean_up(uint32_t flags)
{
ccprintf("Rebooting to clear WP...\n");
cflush();
system_set_scratchpad(TEST_STATE_CLEAN_UP | flags);
system_reset(SYSTEM_RESET_HARD);
}
static void reboot_to_next_step(uint32_t step)
{
ccprintf("Rebooting to next test step...\n");
cflush();
system_set_scratchpad(step);
system_reset(SYSTEM_RESET_HARD);
}
static void run_test_step1(void)
{
error_count = 0;
mock_wp = 0;
RUN_TEST(test_overwrite_current);
RUN_TEST(test_overwrite_other);
RUN_TEST(test_write_protect);
if (error_count) {
ccprintf("Failed %d tests!\n", error_count);
reboot_to_clean_up(CLEAN_UP_FLAG_FAILED);
} else {
reboot_to_next_step(TEST_STATE_STEP_2 | TEST_STATE_BOOT_WP_ON);
}
}
static void run_test_step2(void)
{
RUN_TEST(test_boot_write_protect);
if (error_count) {
ccprintf("Failed %d tests!\n", error_count);
reboot_to_clean_up(CLEAN_UP_FLAG_FAILED);
} else {
reboot_to_next_step(TEST_STATE_STEP_3);
}
}
static void run_test_step3(void)
{
RUN_TEST(test_boot_no_write_protect);
if (error_count) {
ccprintf("Failed %d tests!\n", error_count);
reboot_to_clean_up(CLEAN_UP_FLAG_FAILED);
} else {
reboot_to_clean_up(CLEAN_UP_FLAG_PASSED);
}
}
int TaskTest(void *data)
{
uint32_t state = system_get_scratchpad();
if (state & TEST_STATE_PASSED)
ccprintf("Pass!\n");
if (state & TEST_STATE_STEP_2)
run_test_step2();
else if (state & TEST_STATE_STEP_3)
run_test_step3();
else if (state & TEST_STATE_CLEAN_UP)
clean_up();
return EC_SUCCESS;
}
static int command_run_test(int argc, char **argv)
{
run_test_step1(); /* Never returns */
return EC_ERROR_UNKNOWN;
}
DECLARE_CONSOLE_COMMAND(runtest, command_run_test,
NULL, NULL, NULL);
|