blob: f699803b2e2b4dfe017a634350948bda7e88bdb7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
#!/bin/bash
#
# Copyright 2017 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
excludes=( --exclude-dir=build --exclude=TAGS )
#######################################
# Test if the following conditions hold for the ec host command
# The alpha numeric value of the define starts with 0x
# The alpha numeric value of the define is 4-hex digits
# The hex digits "A B C D E F" are capitalized
# Arguments:
# string - ec host command to check
# Returns:
# 0 if command is ok, else 1
########################################
check_cmd() {
IFS=" "
# Remove any tabs that may exist
tts=$(echo "$1" | sed 's/\t/ /g')
arr=( $tts )
# Check for 0x
if [[ "${arr[2]}" != 0x* ]]; then
return 1
fi
# Check that length is 6. 0x + 4 hex digits
if [[ ${#arr[2]} != 6 ]]; then
return 1
fi
# Check that hex digits are valid and uppercase
hd=${arr[2]:2}
if ! [[ $hd =~ ^[0-9A-F]{4}$ ]]; then
return 1
fi
# command is ok
return 0
}
#######################################
# Test if the string arg is in one of the following formats:
# file.X:#define EC_CMD_X XxXXXX
# file.X:#define EC_PRV_CMD_X XxXXXX
# Arguments:
# string - potential ec host command
# Returns:
# 0 if command is formated properly, else 1
########################################
should_check() {
IFS=" "
arr=( $1 )
# Check for file.X:#define
IFS=":"
temp=( ${arr[0]} )
# Check for file.X
if [ ! -f "${temp[0]}" ]; then
return 1
fi
# Check for #define
if [[ "${temp[1]}" != "#define" ]]; then
return 1
fi
# Check for EC_CMD_XXX or EC_PRV_CMD_XXX
if [[ "${arr[1]}" != EC_CMD_* ]] && [[ "${arr[1]}" != EC_PRV_CMD_* ]]; then
return 1
fi
# Check for EC_XXX_XXX(n)
if [[ "${arr[1]}" =~ ')'$ ]]; then
return 1
fi
return 0
}
main() {
# Do not run the check unless an EC_[xxx]CMD change is present.
if [[ -z "$(git diff --no-ext-diff "${PRESUBMIT_COMMIT}~" \
"${PRESUBMIT_COMMIT}" -U0 |
egrep 'EC_[^ ]*CMD')" ]]; then
exit 0
fi
ec_errors=()
ei=0
# Search all file occurrences of "EC_CMD" and store in array
IFS=$'\n'
ec_cmds=($(grep "${excludes[@]}" -r "EC_CMD"))
# Loop through and find valid occurrences of "EC_CMD" to check
length=${#ec_cmds[@]}
for ((i = 0; i != length; i++)); do
if should_check "${ec_cmds[i]}"; then
if ! check_cmd "${ec_cmds[i]}"; then
ec_errors[$ei]="${ec_cmds[i]}"
((ei++))
fi
fi
done
# Search all file occurrances of "EC_PRV_CMD" and store in array
IFS=$'\n'
ec_prv_cmds=($(grep "${excludes[@]}" -r "EC_PRV_CMD"))
# Loop through and find valid occurrences of "EC_PRV_CMD" to check
length=${#ec_prv_cmds[@]}
for ((i = 0; i != length; i++)); do
if should_check "${ec_prv_cmds[i]}"; then
if ! check_cmd "${ec_prv_cmds[i]}"; then
ec_errors[$ei]="${ec_prv_cmds[i]}"
((ei++))
fi
fi
done
# Check if any malformed ec host commands were found
if [ ! $ei -eq 0 ]; then
echo "The following host commands are malformed:"
# print all malformed host commands
for ((i = 0; i != ei; i++)); do
echo "FILE: ${ec_errors[i]}"
done
exit 1
fi
exit 0
}
main "$@"
|
