summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEvan Benn <evanbenn@chromium.org>2022-12-02 11:21:00 +1100
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-03-29 08:18:22 +0000
commit25d5541cf9a330a4a5e721f3834e0215cd8cadfd (patch)
treeb8af38fc4b0b1f3b40084dc3a2c84d76a02e0ed0
parenteefe01e2738e4393b6a3b66bc9299e637e7fc87f (diff)
downloadvboot-25d5541cf9a330a4a5e721f3834e0215cd8cadfd.tar.gz
futility: Return -1 from read_from_file
Returning errno when there was no libc error was wrong. Return -1. No one checks the error from this function anyway. BUG=b:260531154 BRANCH=None TEST=FEATURES=test emerge-grunt vboot_reference TEST=futility gbb -s --flags 0x0 /tmp/bios /tmp/bios2 Change-Id: Ib91e0917fc1e33a4a95b3874639c3e2fcc5dd1df Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4075305 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4380936 Auto-Submit: Phoebe Wang <phoebewang@chromium.org> Tested-by: Phoebe Wang <phoebewang@chromium.org> Commit-Queue: Cheng Yueh <cyueh@chromium.org> Reviewed-by: Cheng Yueh <cyueh@chromium.org>
-rw-r--r--futility/cmd_gbb_utility.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/futility/cmd_gbb_utility.c b/futility/cmd_gbb_utility.c
index 0f6bebb3..c3dec20d 100644
--- a/futility/cmd_gbb_utility.c
+++ b/futility/cmd_gbb_utility.c
@@ -318,7 +318,7 @@ static int read_from_file(const char *msg, const char *filename,
"ERROR: file %s exceeds capacity (%" PRIu32 ")\n",
filename, size);
errorcnt++;
- r = errno;
+ r = -1;
goto done_close;
}