summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicholas Bishop <nicholasbishop@google.com>2023-02-13 11:46:46 -0500
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-02-14 09:00:13 +0000
commitc00f1b0d670de9a244ff798b0ae52c5cea07f8d9 (patch)
tree074bef9f4a1a317f1bc428da751b80ed8aa6cfb9
parentaa3a7cbbff943e0857df8d273b3288509247cede (diff)
downloadvboot-c00f1b0d670de9a244ff798b0ae52c5cea07f8d9.tar.gz
sign_official_build: Fix shellcheck quoting lints
Fix all instances of "SC2046 (warning): Quote this to prevent word splitting." BRANCH=none BUG=None TEST=cros lint scripts/image_signing/sign_official_build.sh TEST=scripts/image_signing/sign_official_build.sh recovery \ TEST= ~/chromiumos/src/build/images/reven/latest/chromiumos_image.bin TEST= tests/devkeys TEST= ~/chromiumos/src/build/images/reven/latest/chromiumos_image.signed Change-Id: I46a7f3ed0b65e930e7fb95cd97954377a9a09e20 Signed-off-by: Nicholas Bishop <nicholasbishop@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4245620 Reviewed-by: Mike Frysinger <vapier@chromium.org>
-rwxr-xr-xscripts/image_signing/sign_official_build.sh10
1 files changed, 5 insertions, 5 deletions
diff --git a/scripts/image_signing/sign_official_build.sh b/scripts/image_signing/sign_official_build.sh
index a5945433..953d80ca 100755
--- a/scripts/image_signing/sign_official_build.sh
+++ b/scripts/image_signing/sign_official_build.sh
@@ -532,7 +532,7 @@ resign_firmware_payload() {
local bios_path="${shellball_dir}/${bios_image}"
echo "Before EC signing ${bios_path}: md5 =" \
- $(md5sum "${bios_path}" | awk '{print $1}')
+ "$(md5sum "${bios_path}" | awk '{print $1}')"
if [ -n "${ec_image}" ]; then
# Path to ec.bin.
@@ -565,7 +565,7 @@ resign_firmware_payload() {
fi
echo "After EC signing ${bios_path}: md5 =" \
- $(md5sum "${bios_path}" | awk '{print $1}')
+ "$(md5sum "${bios_path}" | awk '{print $1}')"
# Resign bios.bin.
full_command=(
@@ -582,7 +582,7 @@ resign_firmware_payload() {
"${full_command[@]}"
echo "After BIOS signing ${temp_fw}: md5 =" \
- $(md5sum "${temp_fw}" | awk '{print $1}')
+ "$(md5sum "${temp_fw}" | awk '{print $1}')"
# For development phases, when the GBB can be updated still, set the
# recovery and root keys in the image.
@@ -597,7 +597,7 @@ resign_firmware_payload() {
"${full_command[@]}"
echo "After setting GBB on ${bios_path}: md5 =" \
- $(md5sum "${bios_path}" | awk '{print $1}')
+ "$(md5sum "${bios_path}" | awk '{print $1}')"
board_name="$(get_boardvar_from_lsb_release "${rootfs_dir}")"
echo "Board name from lsb-release: ${board_name}"
@@ -1226,7 +1226,7 @@ elif [[ "${TYPE}" == "firmware" ]]; then
elif [[ "${TYPE}" == "update_payload" ]]; then
sign_update_payload "${INPUT_IMAGE}" "${KEY_DIR}" "${OUTPUT_IMAGE}"
elif [[ "${TYPE}" == "accessory_usbpd" ]]; then
- KEY_NAME="${KEY_DIR}/key_$(basename $(dirname "${INPUT_IMAGE}"))"
+ KEY_NAME="${KEY_DIR}/key_$(basename "$(dirname "${INPUT_IMAGE}")")"
if [[ ! -e "${KEY_NAME}.pem" ]]; then
KEY_NAME="${KEY_DIR}/key"
fi