delta/couchdb.git, branch erlfmt-3.x

Apply erlfmt formatting to source tree

2021-11-20T07:09:48+00:00

These exceptions from main were ported over to 3.x

```
--- a/src/chttpd/src/chttpd.erl
+++ b/src/chttpd/src/chttpd.erl
@@ -491,6 +491,7 @@ extract_cookie(#httpd{mochi_req = MochiReq}) ->
     end.
 %%% end hack

+%% erlfmt-ignore
 set_auth_handlers() ->
     AuthenticationDefault =  "{chttpd_auth, cookie_authentication_handler},
```

```
--- a/src/couch/src/couch_debug.erl
+++ b/src/couch/src/couch_debug.erl
@@ -49,6 +49,7 @@ help() ->
     ].

 -spec help(Function :: atom()) -> ok.
+%% erlfmt-ignore
 help(opened_files) ->
```

Port erlfmt formatting to 3.x

2021-11-20T07:08:28+00:00

From PR: #3568

A few changes to the formatting logic compared to `main`:

  * rebar3 and `erlfmt` don't work with Erlang 20, so added an OTP version
    check to skip formatting for Erlang 20

  * `make erlfmt-*` commands are faster. Instead of spawning an `erlfmt`
    process per-file, spawn one per `directory/*.erl` pattern.

  * Remove the non-0 return code work-around. `erlfmt` was returning an error
    on `main` because the line width option used for formatting was different
    than the one used during format checking. Making both the default removed
    all the spurious non-0 exits with the current version of `erlfmt`. Thanks
    to Adam Kocoloski for pointing out the issue.

Reduce skipped integration tests

2021-11-14T16:01:34+00:00

The `skip.elixir` file was ported [1] from FDB-based main branch but
contains more exclusions than necessary for 3.x.

This removes tests from `skip.elixir` that pass on 3.x.

[1] https://github.com/apache/couchdb/commit/65fbc6cfdb29bab1072a42f4d6005da452a7fa65#diff-d9485d6f3162015017bc09c9db3f87df0ca489d961c44347241a035854eb8044

Eliminate elixir test compiler warnings

2021-11-10T21:04:39+00:00

Eliminates the following:

warning: variable "epoch" is unused (if the variable is not meant to be used, prefix it with an underscore)
  src/couchdb/test/elixir/test/replication_test.exs:1756: ReplicationTest.seq_to_shards/1

warning: variable "uuid" is unused (if the variable is not meant to be used, prefix it with an underscore)
  src/couchdb/test/elixir/test/replication_test.exs:1756: ReplicationTest.seq_to_shards/1

warning: variable "string" is unused (if the variable is not meant to be used, prefix it with an underscore)
  src/couchdb/test/elixir/test/utf8_test.exs:32: UTF8Test."test UTF8 support"/1

warning: variable "repeated_view_offset_test_fun" does not exist and is being expanded to "repeated_view_offset_test_fun()", please use parentheses to remove the ambiguity or change the variable name
  src/couchdb/test/elixir/test/view_offsets_test.exs:63: ViewOffsetTest."test repeated view offsets"/1

Using _bulk_docs with new_edits false and without _rev should responds 400 Bad Request

2021-11-08T19:29:35+00:00

Use `weatherreport_check_nodes_connected:check/1`

2021-11-06T16:28:01+00:00

The arity 0 version does not exist.

Fixes dialyzer warning:

{warn_callgraph,{"src/weatherreport_node.erl",126},
                {call_to_missing,[weatherreport_check_nodes_connected,check,
                                  0]}}

Bump version to 3.2.1 and update dependencies

2021-11-03T01:01:20+00:00

Fix reduce view row collation with unicode equivalent keys

2021-11-01T15:47:31+00:00

Previously, view reduce collation with keys relied on the keys in the
rows returned from the view shards to exactly match (=:=) the keys
specified in the args. However, in the case when there are multiple
rows which compare equal with the unicode collator, that may not
always be the case.

In that case when the rows are fetched from the row dict by key, they
should be matched using the same collation algorithm as the one used
on the view shards.

fix(local.ini): straggling s/couch_httpd_auth/chttpd_auth/

2021-10-30T20:08:41+00:00

The appropriately named `hack_local_ini` function in dev/run lives up
to its name by adding a random `secret` to the end of whichever
section contains the line `"; require_valid_user = false\n"`.

Recent commits [1] updated the `setup` application from
`couch_httpd_auth` to `chttpd_auth` without also changing this line
in local.ini, which had the fun effect of causing `setup` to fail with
this error:

```
[error] 2021-10-30T18:50:15.019274Z node1@127.0.0.1 <0.817.0> 85d0421b9c setup sync_admin results [{badrpc,{'EXIT',{function_clause,[{config,set,["chttpd_auth","secret",undefined,true,nil],[{file,"src/config.erl"},{line,189}]},{rpc,'-handle_call_call/6-fun-0-',5,[{file,"rpc.erl"},{line,197}]}]}}},{badrpc,{'EXIT',{function_clause,[{config,set,["chttpd_auth","secret",undefined,true,nil],[{file,"src/config.erl"},{line,189}]},{rpc,'-handle_call_call/6-fun-0-',5,[{file,"rpc.erl"},{line,197}]}]}}}] errors []
[notice] 2021-10-30T18:50:15.019530Z node1@127.0.0.1 <0.817.0> 85d0421b9c 127.0.0.1:15984 127.0.0.1 adm POST /_cluster_setup 500 ok 12
```

This change "fixes" dev/run by also updating the straggling section
name in local.ini.

[1] https://github.com/apache/couchdb/pull/3808

feat(prometheus): allow users with _metrics role to read

2021-10-30T18:30:03+00:00

Closes #3801