summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Shorin <kxepal@apache.org>2014-06-07 01:23:38 +0400
committerAlexander Shorin <kxepal@apache.org>2015-12-03 00:52:00 +0300
commitc001de23d0069905f36d45cb1200d6ba6e125788 (patch)
treefc2e1946540d6fbb98f8ca9bb259e7538e545b75
parent1b8730c959232c9d297f6c4c4ba84c48822cf1dc (diff)
downloadcouchdb-c001de23d0069905f36d45cb1200d6ba6e125788.tar.gz
Port 201-view-group-shutdown.t etap test suite to eunit
Merged into couchdb_views_tests suite. Database population reduced to speedup test and removed second view index call which leaded to race condition when compaction becomes completed in time of view index update call and before assertion check for {error, all_dbs_active}.
-rw-r--r--test/couchdb/couchdb_views_tests.erl183
-rwxr-xr-xtest/etap/201-view-group-shutdown.t293
-rw-r--r--test/etap/Makefile.am1
3 files changed, 183 insertions, 294 deletions
diff --git a/test/couchdb/couchdb_views_tests.erl b/test/couchdb/couchdb_views_tests.erl
index 77ee4f5da..dc6157620 100644
--- a/test/couchdb/couchdb_views_tests.erl
+++ b/test/couchdb/couchdb_views_tests.erl
@@ -94,6 +94,16 @@ view_group_db_leaks_test_() ->
}
}.
+view_group_shutdown_test_() ->
+ {
+ "View group shutdown",
+ {
+ setup,
+ fun start/0, fun stop/1,
+ [couchdb_1283()]
+ }
+ }.
+
should_not_remember_docs_in_index_after_backup_restore_test() ->
%% COUCHDB-640
@@ -229,6 +239,95 @@ couchdb_1309(DbName) ->
end
end).
+couchdb_1283() ->
+ ?_test(begin
+ ok = couch_config:set("couchdb", "max_dbs_open", "3", false),
+ ok = couch_config:set("couchdb", "delayed_commits", "false", false),
+
+ {ok, MDb1} = couch_db:create(?tempdb(), [?ADMIN_USER]),
+ DDoc = couch_doc:from_json_obj({[
+ {<<"_id">>, <<"_design/foo">>},
+ {<<"language">>, <<"javascript">>},
+ {<<"views">>, {[
+ {<<"foo">>, {[
+ {<<"map">>, <<"function(doc) { emit(doc._id, null); }">>}
+ ]}},
+ {<<"foo2">>, {[
+ {<<"map">>, <<"function(doc) { emit(doc._id, null); }">>}
+ ]}},
+ {<<"foo3">>, {[
+ {<<"map">>, <<"function(doc) { emit(doc._id, null); }">>}
+ ]}},
+ {<<"foo4">>, {[
+ {<<"map">>, <<"function(doc) { emit(doc._id, null); }">>}
+ ]}},
+ {<<"foo5">>, {[
+ {<<"map">>, <<"function(doc) { emit(doc._id, null); }">>}
+ ]}}
+ ]}}
+ ]}),
+ {ok, _} = couch_db:update_doc(MDb1, DDoc, []),
+ ok = populate_db(MDb1, 100, 100),
+ query_view(MDb1#db.name, "foo", "foo"),
+ ok = couch_db:close(MDb1),
+
+ {ok, Db1} = couch_db:create(?tempdb(), [?ADMIN_USER]),
+ ok = couch_db:close(Db1),
+ {ok, Db2} = couch_db:create(?tempdb(), [?ADMIN_USER]),
+ ok = couch_db:close(Db2),
+ {ok, Db3} = couch_db:create(?tempdb(), [?ADMIN_USER]),
+ ok = couch_db:close(Db3),
+
+ Writer1 = spawn_writer(Db1#db.name),
+ Writer2 = spawn_writer(Db2#db.name),
+
+ ?assert(is_process_alive(Writer1)),
+ ?assert(is_process_alive(Writer2)),
+
+ %% Below we do exactly the same as couch_mrview:compact holds inside
+ %% because we need have access to compaction Pid, not a Ref.
+ %% {ok, MonRef} = couch_mrview:compact(MDb1#db.name, <<"_design/foo">>,
+ %% [monitor]),
+ {ok, Pid} = couch_index_server:get_index(
+ couch_mrview_index, MDb1#db.name, <<"_design/foo">>),
+ {ok, CPid} = gen_server:call(Pid, compact),
+ %% By suspending compaction process we ensure that compaction won't get
+ %% finished too early to make get_writer_status assertion fail.
+ erlang:suspend_process(CPid),
+ MonRef = erlang:monitor(process, CPid),
+ Writer3 = spawn_writer(Db3#db.name),
+ ?assert(is_process_alive(Writer3)),
+ ?assertEqual({error, all_dbs_active}, get_writer_status(Writer3)),
+
+ ?assert(is_process_alive(Writer1)),
+ ?assert(is_process_alive(Writer2)),
+ ?assert(is_process_alive(Writer3)),
+
+ %% Resume compaction
+ erlang:resume_process(CPid),
+
+ receive
+ {'DOWN', MonRef, process, _, Reason} ->
+ ?assertEqual(normal, Reason)
+ after ?TIMEOUT ->
+ erlang:error(
+ {assertion_failed,
+ [{module, ?MODULE}, {line, ?LINE},
+ {reason, "Failure compacting view group"}]})
+ end,
+
+ ?assertEqual(ok, writer_try_again(Writer3)),
+ ?assertEqual(ok, get_writer_status(Writer3)),
+
+ ?assert(is_process_alive(Writer1)),
+ ?assert(is_process_alive(Writer2)),
+ ?assert(is_process_alive(Writer3)),
+
+ ?assertEqual(ok, stop_writer(Writer1)),
+ ?assertEqual(ok, stop_writer(Writer2)),
+ ?assertEqual(ok, stop_writer(Writer3))
+ end).
+
create_doc(DbName, DocId) when is_list(DocId) ->
create_doc(DbName, ?l2b(DocId));
create_doc(DbName, DocId) when is_binary(DocId) ->
@@ -262,6 +361,20 @@ create_docs(DbName) ->
couch_db:ensure_full_commit(Db),
couch_db:close(Db).
+populate_db(Db, BatchSize, N) when N > 0 ->
+ Docs = lists:map(
+ fun(_) ->
+ couch_doc:from_json_obj({[
+ {<<"_id">>, couch_uuids:new()},
+ {<<"value">>, base64:encode(crypto:rand_bytes(1000))}
+ ]})
+ end,
+ lists:seq(1, BatchSize)),
+ {ok, _} = couch_db:update_docs(Db, Docs, []),
+ populate_db(Db, BatchSize, N - length(Docs));
+populate_db(_Db, _, _) ->
+ ok.
+
create_design_doc(DbName, DDName, ViewName) ->
{ok, Db} = couch_db:open(DbName, [?ADMIN_USER]),
DDoc = couch_doc:from_json_obj({[
@@ -423,3 +536,73 @@ wait_view_compact_done(DbName, DDocId, N) ->
ok = timer:sleep(?DELAY),
wait_view_compact_done(DbName, DDocId, N - 1)
end.
+
+spawn_writer(DbName) ->
+ Parent = self(),
+ spawn(fun() ->
+ process_flag(priority, high),
+ writer_loop(DbName, Parent)
+ end).
+
+get_writer_status(Writer) ->
+ Ref = make_ref(),
+ Writer ! {get_status, Ref},
+ receive
+ {db_open, Ref} ->
+ ok;
+ {db_open_error, Error, Ref} ->
+ Error
+ after ?TIMEOUT ->
+ timeout
+ end.
+
+writer_try_again(Writer) ->
+ Ref = make_ref(),
+ Writer ! {try_again, Ref},
+ receive
+ {ok, Ref} ->
+ ok
+ after ?TIMEOUT ->
+ timeout
+ end.
+
+stop_writer(Writer) ->
+ Ref = make_ref(),
+ Writer ! {stop, Ref},
+ receive
+ {ok, Ref} ->
+ ok
+ after ?TIMEOUT ->
+ erlang:error({assertion_failed,
+ [{module, ?MODULE},
+ {line, ?LINE},
+ {reason, "Timeout on stopping process"}]})
+ end.
+
+writer_loop(DbName, Parent) ->
+ case couch_db:open_int(DbName, []) of
+ {ok, Db} ->
+ writer_loop_1(Db, Parent);
+ Error ->
+ writer_loop_2(DbName, Parent, Error)
+ end.
+
+writer_loop_1(Db, Parent) ->
+ receive
+ {get_status, Ref} ->
+ Parent ! {db_open, Ref},
+ writer_loop_1(Db, Parent);
+ {stop, Ref} ->
+ ok = couch_db:close(Db),
+ Parent ! {ok, Ref}
+ end.
+
+writer_loop_2(DbName, Parent, Error) ->
+ receive
+ {get_status, Ref} ->
+ Parent ! {db_open_error, Error, Ref},
+ writer_loop_2(DbName, Parent, Error);
+ {try_again, Ref} ->
+ Parent ! {ok, Ref},
+ writer_loop(DbName, Parent)
+ end.
diff --git a/test/etap/201-view-group-shutdown.t b/test/etap/201-view-group-shutdown.t
deleted file mode 100755
index c51ec44d2..000000000
--- a/test/etap/201-view-group-shutdown.t
+++ /dev/null
@@ -1,293 +0,0 @@
-#!/usr/bin/env escript
-%% -*- erlang -*-
-
-% Licensed under the Apache License, Version 2.0 (the "License"); you may not
-% use this file except in compliance with the License. You may obtain a copy of
-% the License at
-%
-% http://www.apache.org/licenses/LICENSE-2.0
-%
-% Unless required by applicable law or agreed to in writing, software
-% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-% License for the specific language governing permissions and limitations under
-% the License.
-
--record(user_ctx, {
- name = null,
- roles = [],
- handler
-}).
-
--record(db, {
- main_pid = nil,
- update_pid = nil,
- compactor_pid = nil,
- instance_start_time, % number of microsecs since jan 1 1970 as a binary string
- fd,
- updater_fd,
- fd_ref_counter,
- header = nil,
- committed_update_seq,
- fulldocinfo_by_id_btree,
- docinfo_by_seq_btree,
- local_docs_btree,
- update_seq,
- name,
- filepath,
- validate_doc_funs = [],
- security = [],
- security_ptr = nil,
- user_ctx = #user_ctx{},
- waiting_delayed_commit = nil,
- revs_limit = 1000,
- fsync_options = [],
- options = [],
- compression,
- before_doc_update,
- after_doc_read
-}).
-
-main_db_name() -> <<"couch_test_view_group_shutdown">>.
-
-
-main(_) ->
- test_util:init_code_path(),
-
- etap:plan(17),
- case (catch test()) of
- ok ->
- etap:end_tests();
- Other ->
- etap:diag(io_lib:format("Test died abnormally: ~p", [Other])),
- etap:bail(Other)
- end,
- ok.
-
-
-test() ->
- couch_server_sup:start_link(test_util:config_files()),
- ok = couch_config:set("couchdb", "max_dbs_open", "3", false),
- ok = couch_config:set("couchdb", "delayed_commits", "false", false),
- crypto:start(),
-
- % Test that while a view group is being compacted its database can not
- % be closed by the database LRU system.
- test_view_group_compaction(),
-
- couch_server_sup:stop(),
- ok.
-
-
-test_view_group_compaction() ->
- {ok, DbWriter3} = create_db(<<"couch_test_view_group_shutdown_w3">>),
- ok = couch_db:close(DbWriter3),
-
- {ok, MainDb} = create_main_db(),
- ok = couch_db:close(MainDb),
-
- {ok, DbWriter1} = create_db(<<"couch_test_view_group_shutdown_w1">>),
- ok = couch_db:close(DbWriter1),
-
- {ok, DbWriter2} = create_db(<<"couch_test_view_group_shutdown_w2">>),
- ok = couch_db:close(DbWriter2),
-
- Writer1 = spawn_writer(DbWriter1#db.name),
- Writer2 = spawn_writer(DbWriter2#db.name),
- etap:is(is_process_alive(Writer1), true, "Spawned writer 1"),
- etap:is(is_process_alive(Writer2), true, "Spawned writer 2"),
-
- etap:is(get_writer_status(Writer1), ok, "Writer 1 opened his database"),
- etap:is(get_writer_status(Writer2), ok, "Writer 2 opened his database"),
-
- {ok, MonRef} = couch_mrview:compact(MainDb#db.name, <<"_design/foo">>, [monitor]),
-
- % Add some more docs to database and trigger view update
- {ok, MainDb2} = couch_db:open_int(MainDb#db.name, []),
- ok = populate_main_db(MainDb2, 3, 3),
- update_view(MainDb2#db.name, <<"_design/foo">>, <<"foo">>),
- ok = couch_db:close(MainDb2),
-
- % Assuming the view compaction takes more than 50ms to complete
- ok = timer:sleep(50),
- Writer3 = spawn_writer(DbWriter3#db.name),
- etap:is(is_process_alive(Writer3), true, "Spawned writer 3"),
-
- etap:is(get_writer_status(Writer3), {error, all_dbs_active},
- "Writer 3 got {error, all_dbs_active} when opening his database"),
-
- etap:is(is_process_alive(Writer1), true, "Writer 1 still alive"),
- etap:is(is_process_alive(Writer2), true, "Writer 2 still alive"),
- etap:is(is_process_alive(Writer3), true, "Writer 3 still alive"),
-
- receive
- {'DOWN', MonRef, process, _, normal} ->
- etap:diag("View group compaction successful"),
- ok;
- {'DOWN', MonRef, process, _, _Reason} ->
- etap:bail("Failure compacting view group")
- end,
-
- ok = timer:sleep(2000),
-
- etap:is(writer_try_again(Writer3), ok,
- "Told writer 3 to try open his database again"),
- etap:is(get_writer_status(Writer3), ok,
- "Writer 3 was able to open his database"),
-
- etap:is(is_process_alive(Writer1), true, "Writer 1 still alive"),
- etap:is(is_process_alive(Writer2), true, "Writer 2 still alive"),
- etap:is(is_process_alive(Writer3), true, "Writer 3 still alive"),
-
- etap:is(stop_writer(Writer1), ok, "Stopped writer 1"),
- etap:is(stop_writer(Writer2), ok, "Stopped writer 2"),
- etap:is(stop_writer(Writer3), ok, "Stopped writer 3"),
-
- delete_db(MainDb),
- delete_db(DbWriter1),
- delete_db(DbWriter2),
- delete_db(DbWriter3).
-
-
-create_main_db() ->
- {ok, Db} = create_db(main_db_name()),
- DDoc = couch_doc:from_json_obj({[
- {<<"_id">>, <<"_design/foo">>},
- {<<"language">>, <<"javascript">>},
- {<<"views">>, {[
- {<<"foo">>, {[
- {<<"map">>, <<"function(doc) { emit(doc._id, doc); }">>}
- ]}},
- {<<"foo2">>, {[
- {<<"map">>, <<"function(doc) { emit(doc._id, doc); }">>}
- ]}},
- {<<"foo3">>, {[
- {<<"map">>, <<"function(doc) { emit(doc._id, doc); }">>}
- ]}},
- {<<"foo4">>, {[
- {<<"map">>, <<"function(doc) { emit(doc._id, doc); }">>}
- ]}},
- {<<"foo5">>, {[
- {<<"map">>, <<"function(doc) { emit(doc._id, doc); }">>}
- ]}}
- ]}}
- ]}),
- {ok, _} = couch_db:update_doc(Db, DDoc, []),
- ok = populate_main_db(Db, 1000, 20000),
- update_view(Db#db.name, <<"_design/foo">>, <<"foo">>),
- {ok, Db}.
-
-
-populate_main_db(Db, BatchSize, N) when N > 0 ->
- Docs = lists:map(
- fun(_) ->
- couch_doc:from_json_obj({[
- {<<"_id">>, couch_uuids:new()},
- {<<"value">>, base64:encode(crypto:rand_bytes(1000))}
- ]})
- end,
- lists:seq(1, BatchSize)),
- {ok, _} = couch_db:update_docs(Db, Docs, []),
- populate_main_db(Db, BatchSize, N - length(Docs));
-populate_main_db(_Db, _, _) ->
- ok.
-
-
-update_view(DbName, DDocName, ViewName) ->
- {ok, Db} = couch_db:open_int(DbName, []),
- {ok, DDoc} = couch_db:open_doc(Db, DDocName, [ejson_body]),
- couch_mrview:query_view(Db, DDoc, ViewName, [{stale, false}]),
- ok = couch_db:close(Db),
- etap:diag("View group updated").
-
-
-create_db(DbName) ->
- {ok, Db} = couch_db:create(
- DbName,
- [{user_ctx, #user_ctx{roles = [<<"_admin">>]}}, overwrite]),
- {ok, Db}.
-
-
-delete_db(#db{name = DbName, main_pid = Pid}) ->
- ok = couch_server:delete(
- DbName, [{user_ctx, #user_ctx{roles = [<<"_admin">>]}}]),
- MonRef = erlang:monitor(process, Pid),
- receive
- {'DOWN', MonRef, process, Pid, _Reason} ->
- ok
- after 30000 ->
- etap:bail("Timeout deleting database")
- end.
-
-
-spawn_writer(DbName) ->
- Parent = self(),
- spawn(fun() ->
- process_flag(priority, high),
- writer_loop(DbName, Parent)
- end).
-
-
-get_writer_status(Writer) ->
- Ref = make_ref(),
- Writer ! {get_status, Ref},
- receive
- {db_open, Ref} ->
- ok;
- {db_open_error, Error, Ref} ->
- Error
- after 5000 ->
- timeout
- end.
-
-
-writer_try_again(Writer) ->
- Ref = make_ref(),
- Writer ! {try_again, Ref},
- receive
- {ok, Ref} ->
- ok
- after 5000 ->
- timeout
- end.
-
-
-stop_writer(Writer) ->
- Ref = make_ref(),
- Writer ! {stop, Ref},
- receive
- {ok, Ref} ->
- ok
- after 5000 ->
- etap:bail("Timeout stopping writer process")
- end.
-
-
-% Just keep the database open, no need to actually do something on it.
-writer_loop(DbName, Parent) ->
- case couch_db:open_int(DbName, []) of
- {ok, Db} ->
- writer_loop_1(Db, Parent);
- Error ->
- writer_loop_2(DbName, Parent, Error)
- end.
-
-writer_loop_1(Db, Parent) ->
- receive
- {get_status, Ref} ->
- Parent ! {db_open, Ref},
- writer_loop_1(Db, Parent);
- {stop, Ref} ->
- ok = couch_db:close(Db),
- Parent ! {ok, Ref}
- end.
-
-writer_loop_2(DbName, Parent, Error) ->
- receive
- {get_status, Ref} ->
- Parent ! {db_open_error, Error, Ref},
- writer_loop_2(DbName, Parent, Error);
- {try_again, Ref} ->
- Parent ! {ok, Ref},
- writer_loop(DbName, Parent)
- end.
diff --git a/test/etap/Makefile.am b/test/etap/Makefile.am
index 678b1b6c3..c4918fa30 100644
--- a/test/etap/Makefile.am
+++ b/test/etap/Makefile.am
@@ -32,7 +32,6 @@ fixture_files = \
fixtures/test.couch
tap_files = \
- 201-view-group-shutdown.t \
210-os-proc-pool.t \
220-compaction-daemon.t \
230-pbkfd2.t \