summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Newson <rnewson@apache.org>2020-03-16 22:39:16 +0000
committerRobert Newson <rnewson@apache.org>2020-04-27 21:05:13 +0100
commit63e2d08e6d580f89f95778e46d8c5a3f76ffa052 (patch)
tree6e6edbdd5a40b3223acf78e0ba2af25c6de2db91
parentb7ca42d6ba9cddc8878a09498a2167d36ddb71b8 (diff)
downloadcouchdb-63e2d08e6d580f89f95778e46d8c5a3f76ffa052.tar.gz
View is partitioned if db and view are partitioned
We've seen a crash if DbPartitioned is false and ViewPartitioned is true, which is obviously nonsense. The effect of the `nocase` is the termination of the couch_index_server gen_server, which is a serious amplification of a small (user-initiated) oddity.
-rw-r--r--src/couch_mrview/src/couch_mrview_index.erl11
1 files changed, 1 insertions, 10 deletions
diff --git a/src/couch_mrview/src/couch_mrview_index.erl b/src/couch_mrview/src/couch_mrview_index.erl
index cc013c5bd..68f1d2322 100644
--- a/src/couch_mrview/src/couch_mrview_index.erl
+++ b/src/couch_mrview/src/couch_mrview_index.erl
@@ -258,16 +258,7 @@ set_partitioned(Db, State) ->
DbPartitioned = couch_db:is_partitioned(Db),
ViewPartitioned = couch_util:get_value(
<<"partitioned">>, DesignOpts, DbPartitioned),
- IsPartitioned = case {DbPartitioned, ViewPartitioned} of
- {true, true} ->
- true;
- {true, false} ->
- false;
- {false, false} ->
- false;
- _ ->
- throw({bad_request, <<"invalid partition option">>})
- end,
+ IsPartitioned = DbPartitioned andalso ViewPartitioned,
State#mrst{partitioned = IsPartitioned}.