| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Since the db structure returned from fabric2_db:open and fabric2_db:create
includes `user_ctx` and `request_ctx` there is no need to pass it explicitelly
in every `fabric2_db` call. This means we can simplify few things:
- Don't pass user_ctx in `chttpd_db:db_req/2` since we pass db already
- Don't have to use `db_open_options` in `chttpd_changes`
- Don't have to pass `user_ctx` to `fabric2_db:open_doc` and `fabric2_db:update_doc`
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to implement end-to-end testing we need to pass some information
through all layers. We would use a `request_ctx` map to achive that.
The information we might want to pass is (TBD):
- is_sampled : true | false
- is_enabled : true | false
- trace_id : uuid
- parent_span_id : uuid
This commit passes the `request_ctx` to `fabric2:list_dbs`.
In subsequent commits we would pass `request_ctx` in `Options`
to other functions in `fabric2`.
|
| |
|
|
|
|
|
| |
A note for curious observer:
We wouldn't be finishing a span on exit because we don't
want to spam our trace collector with client disconnects.
The open tracing library handles this case just fine.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The history of `send_error(_Req, {already_sent, Resp, _Error})`
clause is bellow:
- it was added on [2009/04/18](https://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_httpd.erl?r1=762574&r2=765819&diff_format=h)
- we triggered that clause [in couch_httpd:do](https://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_httpd.erl?revision=642432&view=markup#l88)
- at that time we were using inets webserver [see use of `httpd_response/3`](https://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_httpd.erl?revision=642432&view=markup#l170)
- The inets OTP codebase uses `already_sent` messages [here](https://github.com/erlang/otp/blob/50214f02501926fee6ec286efa68a57a47c2e531/lib/inets/src/http_server/httpd_response.erl#L220)
It should be safe to remove this clause because we are not using inets anymore
and search of `already_sent` term across all dependencies doesn't return any results.
|
| |
|
|
|
|
|
|
|
| |
We test that a newly deleted document is replicated to the target and it bumps
the deled doc count but doesn't change doc count.
Another thing to test is that an already deleted document is replicated in
where its revision path was extended on the source then gets replicated to the
target. In that case neither del doc count not doc count are bumped.
|
| |
|
|
|
|
|
|
|
|
|
| |
Do not decrement `doc_count` stat if document was previously missing, or if it
was already deleted.
Deleted documents could be brought in by replication. In that case, if there
were more replicated documents than the current `doc_count`, the `doc_count`
could even underflow the 64 bit unsigned integer range and end up somewhere in
the vicinity of 2^64. The counter, of course, would still be incorrect even if
it didn't underflow, the huge value would just make the issue more visible.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings this to parity with master `couch_db:open/2` logic:
https://github.com/apache/couchdb/blob/master/src/couch/src/couch_db.erl#L166
There are two separate cases that have to be handled:
1) Db was already opened and cached. In that case, call `check_is_member(Db)`
which reads the security from the Db to ensure we don't authorize against a
stale security doc. Otherwise, the delay could be as long as the last write
that went through that node. A potential future optimization could be to have
a timestamp and only get the new security context if last refresh hasn't
happened recently.
2) Db was not cached, and was just opened. To avoid running another two read
transactions to get the security doc after the main transaction finished, call
a version of check_is_member which gets the security doc passed in as an
argument.
As a bonus, `check_is_members(Db, SecDoc)` version ends up saving one extra
security read since we don't read twice in is_member and is_admin calls.
`delete/2` was updated to pass ?ADMIN_CTX to `open/2` since it only cares about
getting a `database_does_not_exist` error thrown. There is a check for server
admin at the HTTP API level that would care of authentication / authorization.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two fixes:
1) In `fabric2_fdb:get_config/1`, Db was matched before and after
`ensure_current/1`. Only the db prefix path was used, which doesn't normally
change, but it's worth fixing it anyway.
2) We used a cached version of the security document outside the transaction.
Now we force it go through a transaction to call `fabric2_fdb:get_config/1`
which call `ensure_current/1`. When done, we also update the cached Db handle.
Do the same thing for revs_limit even thought it is not as critical as
security.
|
| | |
|
| |\
| |
| | |
Support `--extra_args` parameter in `dev/run`
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes there is a need to specify additional arguments for the beam process we start from dev/run.
In particular the feature is handy for:
- changing emulator flags
- simulate OOM via available RAM restrictions
- enable module loading tracing
- configure number of schedulers
- modify applications configuration
- run customization script to add extra development deps (such as automatic code reload)
Historically developers had to edit dev/run to do it.
This PR adds an ability to specify additional arguments via `--extra_args` argument.
In order to run customization script create `customization.erl` which exports `start/0` and run it using:
```
dev/run --extra_args='-run customization'
```
|
| |
|
|
|
|
|
|
| |
`TimeoutFun` was already returning `{ok|stop, UserAcc}` so there was no need to
wrap it another `{ok, ...} tuple.
Also TimeoutFun was calling user with`{timeout, _ResponseType}` not just
timeout, so added a clause to handle that as well.
|
| | |
|
| |
|
|
|
| |
On master this is happening in `fabric_view_changes` but on FDB we don't go
through that module anymore, so we do in `chttpd_changes` module instead.
|
| |
|
|
|
|
|
|
|
|
|
| |
On master `_local_docs&update_seq=true` returns the update sequence of the
database. Even though it might not make much sense since updating local docs
doesn't bump the sequence, it's probably a good idea to stay consistent.
It's also worth mentioning another inconsistency is when FDB returns a
`total_rows` count for `_local_docs` while master returns `null`. I think
that's probably acceptable. Master would return the count if had it available
easily and having it seems like a useful thing and an improvement.
|
| |
|
|
|
|
|
| |
This is done for compatibility with CouchDB < 4.x where this limit was
implicitly enforced by the file system's max filename size. The default value
enforces the same limit for FDB in case users decide to replicate back and
forth between old and new instances with 'create_target = true' option.
|
| |
|
|
|
|
|
|
|
| |
`_design_docs` reuses `_all_docs` logic and adjusts `start_key` and
`end_key` to be within the `_design/` prefix range.
Namespace setting was simplified to never have an `undefined`
value. This way it doesn't need extra case statements to handle it
further down in the FDB code.
|
| |
|
|
|
| |
Also add mrargs validation to match what master does and provide some
helpful feedback to the users.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This matches behavior on master:
https://github.com/apache/couchdb/blob/master/src/couch/src/couch_db.erl#L1373-L1387
|
| |
|
|
|
| |
Start stop config and couch_drv in `setup/0` and `teardown/1` instead of the
test function itself.
|
| | |
|
| | |
|
| |
|
|
| |
That is needed when indexing authentication dbs like `_users`.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously if a VDU was updated in the `before_doc_update/3` handlers, the Db
handle wasn't refreshed soon enough such that the `prepare_and_validate/3`
would not see the newly update VDU and would not run it.
To fix make a stale Db throws an exception which bubbles up all the way to
`fabric2_fdb:transactional/2` where the transaction is retried again with a
reopened Db.
During `reopen/1` make sure to properly transfer the `user_ctx` property to the
new handle, and also make sure `user_ctx` is removed from `db_options` to avoid
caching it in `fabric2_server`.
|
| |
|
|
|
|
| |
This mostly equivalent to the `couch_db` EPI plugin, but using fabric2 calls
and without some of the functions that are not relevant to FDB such as
on_compact/1 and others.
|
| | |
|
| |\
| |
| |
| |
| | |
cloudant/add-timeout-to-fold_docs_with_different_keys
Add timeout for 'fold_docs-with_different_keys' test
|
| |/ |
|
| | |
|
| |
|
|
|
|
|
| |
Specifying a custom prefix allows having multiple CouchDB instances on a single
FDB cluster. This can be used for one form of multi-tenancy. It can also be
used for integration testing by creating a temporary prefix then deleting all
data in that directory when the test has finished.
|
| | |
|
| |
|
|
|
| |
This opens the max document size to the transaction limits rather than a
single 100k value.
|
| | |
|
| |
|
|
|
|
| |
If the indexing job has timed out and has been requed we need to exit
the current indexer. This ensures the errors are logged so that we can
keep an eye on failing jobs.
|
| |
|
|
|
|
| |
This adds couch_views which builds map indexes and stores them in FDB.
Co-authored-by: Paul J. Davis <paul.joseph.davis@gmail.com>
|
| |
|
|
|
| |
If a start or end key is not specified we still need to scope the range
read to the given `RangePrefix`.
|
| |
|
|
|
| |
This exposes a single place where we can check for whether a given
database or database name is a replicator or users database.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
The old test got around this by using couch_httpd_auth cache in its
tests which is fairly odd given that we run chttpd_auth_cache in
production. This fixes that mistake and upgrades chttpd_auth_cache so
that it works in the test scenario of changing the authentication_db
configuration.
|
| | |
|
