From 2ccde31ef9adfd02ef7c2f303a62bb6ab0a1cc9d Mon Sep 17 00:00:00 2001 From: Jay Doane Date: Thu, 20 Feb 2020 22:06:43 -0800 Subject: Improve validate_dbname test It's possible for other couch_epi plugins to interfere with this test, so mock `couch_epi:decide/5` to always return `no_decision`. --- src/fabric/test/fabric2_db_misc_tests.erl | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/fabric/test/fabric2_db_misc_tests.erl b/src/fabric/test/fabric2_db_misc_tests.erl index c48ee2c73..42a63e2f9 100644 --- a/src/fabric/test/fabric2_db_misc_tests.erl +++ b/src/fabric/test/fabric2_db_misc_tests.erl @@ -141,7 +141,15 @@ validate_dbname(_) -> Expect = {error, {Reason, DbName}}, ?assertEqual(Expect, fabric2_db:validate_dbname(DbName)) end, - lists:foreach(CheckFun, Tests). + try + % Don't allow epi plugins to interfere with test results + meck:new(couch_epi, [passthrough]), + meck:expect(couch_epi, decide, 5, no_decision), + lists:foreach(CheckFun, Tests) + after + % Unload within the test to minimize interference with other tests + meck:unload() + end. validate_doc_ids(_) -> -- cgit v1.2.1