diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2015-07-31 17:49:43 +0200 |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2015-07-31 17:49:43 +0200 |
commit | db75e0dbc154cf1f0ed0bbc70e591e9c88b71426 (patch) | |
tree | ebe1506e5f10d3585ea44339fa57ac40102ad969 /Lib/test/test_asyncio/test_subprocess.py | |
parent | c3446ddaaf4aa978be0249e6036182b8a6bc5bd2 (diff) | |
download | cpython-db75e0dbc154cf1f0ed0bbc70e591e9c88b71426.tar.gz |
Fix ResourceWarning in asyncio.BaseSubprocessTransport
Issue #24763: Fix resource warnings when asyncio.BaseSubprocessTransport
constructor fails, if subprocess.Popen raises an exception for example.
Patch written by Martin Richard, test written by me.
Diffstat (limited to 'Lib/test/test_asyncio/test_subprocess.py')
-rw-r--r-- | Lib/test/test_asyncio/test_subprocess.py | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/Lib/test/test_asyncio/test_subprocess.py b/Lib/test/test_asyncio/test_subprocess.py index ea85e1912e..d138c263c1 100644 --- a/Lib/test/test_asyncio/test_subprocess.py +++ b/Lib/test/test_asyncio/test_subprocess.py @@ -1,6 +1,7 @@ import signal import sys import unittest +import warnings from unittest import mock import asyncio @@ -413,6 +414,20 @@ class SubprocessMixin: # the transport was not notified yet self.assertFalse(killed) + def test_popen_error(self): + # Issue #24763: check that the subprocess transport is closed + # when BaseSubprocessTransport fails + with mock.patch('subprocess.Popen') as popen: + exc = ZeroDivisionError + popen.side_effect = exc + + create = asyncio.create_subprocess_exec(sys.executable, '-c', + 'pass', loop=self.loop) + with warnings.catch_warnings(record=True) as warns: + with self.assertRaises(exc): + self.loop.run_until_complete(create) + self.assertEqual(warns, []) + if sys.platform != 'win32': # Unix |