diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2012-03-09 00:39:08 +0100 |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2012-03-09 00:39:08 +0100 |
commit | ea7f7fe101c7abf68c104949a92df1e3334698f8 (patch) | |
tree | 8d79add14b55a9b086c0648477eac1f2ba0e34c3 /Lib/test/test_descr.py | |
parent | dcca66e27d94fd13e12889d7edfb9646e46b89ad (diff) | |
download | cpython-ea7f7fe101c7abf68c104949a92df1e3334698f8.tar.gz |
Close #14199: _PyType_Lookup() and super_getattro() keep a strong reference to
the type MRO to avoid a crash if the MRO is changed during the lookup.
Diffstat (limited to 'Lib/test/test_descr.py')
-rw-r--r-- | Lib/test/test_descr.py | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py index 45fd05dd4b..f405fbbb57 100644 --- a/Lib/test/test_descr.py +++ b/Lib/test/test_descr.py @@ -4582,10 +4582,38 @@ class PTypesLongInitTest(unittest.TestCase): type.mro(tuple) +class MiscTests(unittest.TestCase): + def test_type_lookup_mro_reference(self): + # Issue #14199: _PyType_Lookup() has to keep a strong reference to + # the type MRO because it may be modified during the lookup, if + # __bases__ is set during the lookup for example. + class MyKey(object): + def __hash__(self): + return hash('mykey') + + def __eq__(self, other): + X.__bases__ = (Base2,) + + class Base(object): + mykey = 'from Base' + mykey2 = 'from Base' + + class Base2(object): + mykey = 'from Base2' + mykey2 = 'from Base2' + + X = type('X', (Base,), {MyKey(): 5}) + # mykey is read from Base + self.assertEqual(X.mykey, 'from Base') + # mykey2 is read from Base2 because MyKey.__eq__ has set __bases__ + self.assertEqual(X.mykey2, 'from Base2') + + def test_main(): # Run all local test cases, with PTypesLongInitTest first. support.run_unittest(PTypesLongInitTest, OperatorsTest, - ClassPropertiesAndMethods, DictProxyTests) + ClassPropertiesAndMethods, DictProxyTests, + MiscTests) if __name__ == "__main__": test_main() |