summaryrefslogtreecommitdiff
path: root/Python/compile.c
diff options
context:
space:
mode:
authorGuido van Rossum <guido@python.org>2006-03-10 02:28:35 +0000
committerGuido van Rossum <guido@python.org>2006-03-10 02:28:35 +0000
commit95737a4c2708964d58d9335fb55dd016e2ec0b9d (patch)
treeb751a0f79c9d181f00fff6aed5b58e0b838b43a8 /Python/compile.c
parent5c78f048a13c032f08de75dd5e8c10c830d42ca9 (diff)
downloadcpython-95737a4c2708964d58d9335fb55dd016e2ec0b9d.tar.gz
Um, I thought I'd already checked this in.
Anyway, this is the changes to the with-statement so that __exit__ must return a true value in order for a pending exception to be ignored. The PEP (343) is already updated.
Diffstat (limited to 'Python/compile.c')
-rw-r--r--Python/compile.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/Python/compile.c b/Python/compile.c
index c07b6d346d..e3b3df8f62 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -1382,7 +1382,7 @@ opcode_stack_effect(int opcode, int oparg)
case BREAK_LOOP:
return 0;
case WITH_CLEANUP:
- return 3;
+ return -1; /* XXX Sometimes more */
case LOAD_LOCALS:
return 1;
case RETURN_VALUE:
@@ -3472,8 +3472,6 @@ compiler_with(struct compiler *c, stmt_ty s)
!compiler_nameop(c, tmpexit, Del))
return 0;
ADDOP(c, WITH_CLEANUP);
- ADDOP_I(c, CALL_FUNCTION, 3);
- ADDOP(c, POP_TOP);
/* Finally block ends. */
ADDOP(c, END_FINALLY);