From 942b498d0ff21ef9581a7eb0c8e73953b55febb3 Mon Sep 17 00:00:00 2001 From: Martin Panter Date: Thu, 22 Sep 2016 09:34:43 +0000 Subject: Issue #27950: Silence long makefile commands and comments Gnu Make treats comments in a list of commands as shell comments (not makefile comments), and reports them as shell commands. The space separating the @ and # symbols helps syntax highlighting. --- Makefile.pre.in | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) (limited to 'Makefile.pre.in') diff --git a/Makefile.pre.in b/Makefile.pre.in index 292abb39b0..18ba615c3f 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -497,7 +497,7 @@ build_all_generate_profile: $(MAKE) @DEF_MAKE_RULE@ CFLAGS_NODIST="$(CFLAGS) $(PGO_PROF_GEN_FLAG) @LTOFLAGS@" LDFLAGS="$(LDFLAGS) $(PGO_PROF_GEN_FLAG) @LTOFLAGS@" LIBS="$(LIBS)" run_profile_task: - : # FIXME: can't run for a cross build + @ # FIXME: can't run for a cross build $(LLVM_PROF_FILE) $(RUNSHARED) ./$(BUILDPYTHON) $(PROFILE_TASK) || true build_all_merge_profile: @@ -521,8 +521,8 @@ coverage-lcov: --base-directory $(realpath $(abs_builddir)) \ --path $(realpath $(abs_srcdir)) \ --output-file $(COVERAGE_INFO) - : # remove 3rd party modules, system headers and internal files with - : # debug, test or dummy functions. + @ # remove 3rd party modules, system headers and internal files with + @ # debug, test or dummy functions. @lcov --remove $(COVERAGE_INFO) \ '*/Modules/_blake2/impl/*' \ '*/Modules/_ctypes/libffi*/*' \ @@ -546,15 +546,15 @@ coverage-lcov: @echo coverage-report: - : # force rebuilding of parser and importlib + @ # force rebuilding of parser and importlib @touch $(GRAMMAR_INPUT) @touch $(srcdir)/Lib/importlib/_bootstrap.py @touch $(srcdir)/Lib/importlib/_bootstrap_external.py - : # build with coverage info + @ # build with coverage info $(MAKE) coverage - : # run tests, ignore failures + @ # run tests, ignore failures $(TESTRUNNER) $(TESTOPTS) || true - : # build lcov report + @ # build lcov report $(MAKE) coverage-lcov # Run "Argument Clinic" over all source files @@ -1020,7 +1020,7 @@ testall: all platform # Run the test suite for both architectures in a Universal build on OSX. # Must be run on an Intel box. testuniversal: all platform - if [ `arch` != 'i386' ];then \ + @if [ `arch` != 'i386' ]; then \ echo "This can only be used on OSX/i386" ;\ exit 1 ;\ fi @@ -1343,15 +1343,15 @@ libinstall: build_all $(srcdir)/Modules/xxmodule.c $(PYTHON_FOR_BUILD) -m lib2to3.pgen2.driver $(DESTDIR)$(LIBDEST)/lib2to3/PatternGrammar.txt python-config: $(srcdir)/Misc/python-config.in Misc/python-config.sh - # Substitution happens here, as the completely-expanded BINDIR - # is not available in configure + @ # Substitution happens here, as the completely-expanded BINDIR + @ # is not available in configure sed -e "s,@EXENAME@,$(BINDIR)/python$(LDVERSION)$(EXE)," < $(srcdir)/Misc/python-config.in >python-config.py - # Replace makefile compat. variable references with shell script compat. ones; $(VAR) -> ${VAR} + @ # Replace makefile compat. variable references with shell script compat. ones; $(VAR) -> ${VAR} sed -e 's,\$$(\([A-Za-z0-9_]*\)),\$$\{\1\},g' < Misc/python-config.sh >python-config - # On Darwin, always use the python version of the script, the shell - # version doesn't use the compiler customizations that are provided - # in python (_osx_support.py). - if test `uname -s` = Darwin; then \ + @ # On Darwin, always use the python version of the script, the shell + @ # version doesn't use the compiler customizations that are provided + @ # in python (_osx_support.py). + @if test `uname -s` = Darwin; then \ cp python-config.py python-config; \ fi -- cgit v1.2.1 From adf717bbaed3e9ddbaa0d2d75f2ef25366968a74 Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Sat, 1 Oct 2016 16:15:09 -0500 Subject: Issue #13756: Fix building extensions modules on Cygwin Patch by Roumen Petrov, based on original patch by Jason Tishler. --- Makefile.pre.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile.pre.in') diff --git a/Makefile.pre.in b/Makefile.pre.in index a2174cea8b..ce5296eb29 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -674,7 +674,7 @@ $(PYTHONFRAMEWORKDIR)/Versions/$(VERSION)/$(PYTHONFRAMEWORK): \ # This rule builds the Cygwin Python DLL and import library if configured # for a shared core library; otherwise, this rule is a noop. -$(DLLLIBRARY) libpython$(VERSION).dll.a: $(LIBRARY_OBJS) +$(DLLLIBRARY) libpython$(LDVERSION).dll.a: $(LIBRARY_OBJS) if test -n "$(DLLLIBRARY)"; then \ $(LDSHARED) -Wl,--out-implib=$@ -o $(DLLLIBRARY) $^ \ $(LIBS) $(MODLIBS) $(SYSLIBS) $(LDLAST); \ -- cgit v1.2.1