From dfc47a8b931a2e519e292278fb641e7f6b2d47e7 Mon Sep 17 00:00:00 2001 From: Hye-Shik Chang Date: Tue, 7 Mar 2006 15:39:21 +0000 Subject: SF #1444030: Fix several potential defects found by Coverity. (reviewed by Neal Norwitz) --- Python/traceback.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'Python/traceback.c') diff --git a/Python/traceback.c b/Python/traceback.c index 7b83d8b02d..6c11cf5274 100644 --- a/Python/traceback.c +++ b/Python/traceback.c @@ -185,8 +185,12 @@ tb_displayline(PyObject *f, char *filename, int lineno, char *name) } PyOS_snprintf(linebuf, sizeof(linebuf), FMT, filename, lineno, name); err = PyFile_WriteString(linebuf, f); - if (xfp == NULL || err != 0) + if (xfp == NULL) return err; + else if (err != 0) { + fclose(xfp); + return err; + } for (i = 0; i < lineno; i++) { char* pLastChar = &linebuf[sizeof(linebuf)-2]; do { -- cgit v1.2.1