From 76b73c746851f94f8d5e6c5150413d534e9c2c8d Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 8 Dec 2022 23:45:18 +0100 Subject: tool_formparse: avoid clobbering on function params While perfectly legal to do, clobbering function parameters and using them as local variables is confusing at best and rarely improves code readability. Fix by using a local variable instead, no functionality is changed. This also renames the parameter from data to mime_data since the term data is (soft) reserved for the easy handle struct. Closes: #10046 Reviewed-by: Daniel Stenberg --- src/tool_formparse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/tool_formparse.c b/src/tool_formparse.c index d4fc651e2..5dc24fe7e 100644 --- a/src/tool_formparse.c +++ b/src/tool_formparse.c @@ -61,17 +61,18 @@ static struct tool_mime *tool_mime_new_parts(struct tool_mime *parent) } static struct tool_mime *tool_mime_new_data(struct tool_mime *parent, - char *data) + char *mime_data) { + char *mime_data_copy; struct tool_mime *m = NULL; - data = strdup(data); - if(data) { + mime_data_copy = strdup(mime_data); + if(mime_data_copy) { m = tool_mime_new(parent, TOOLMIME_DATA); if(!m) - free(data); + free(mime_data_copy); else - m->data = data; + m->data = mime_data_copy; } return m; } -- cgit v1.2.1