summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Kraft <george.kraft@calxeda.com>2013-05-03 13:50:52 -0500
committerGeorge Kraft <george.kraft@calxeda.com>2013-05-03 13:50:52 -0500
commit3f29af0d6b9686f64e3d7a4ab6705d02fe1119cc (patch)
tree544f0bf54b7626e2dfa37695895843681eaf473b
parent3656128eed018e8e225b1acd49c6d73af30abf51 (diff)
downloadcxmanage-3f29af0d6b9686f64e3d7a4ab6705d02fe1119cc.tar.gz
Fabric: Re-order a couple of methods
Just group the nodes and primary_nodes properties together, and move private methods to the bottom.
-rw-r--r--cxmanage_api/fabric.py60
1 files changed, 30 insertions, 30 deletions
diff --git a/cxmanage_api/fabric.py b/cxmanage_api/fabric.py
index 3a7b2b9..321968b 100644
--- a/cxmanage_api/fabric.py
+++ b/cxmanage_api/fabric.py
@@ -139,6 +139,20 @@ class Fabric(object):
self._discover_nodes(self.ip_address)
return self._nodes
+ @property
+ def primary_node(self):
+ """The node to use for fabric config operations.
+
+ Today, this is always node 0.
+
+ >>> fabric.primary_node
+ <cxmanage_api.node.Node object at 0x210d790>
+
+ :return: Node object for primary node
+ :rtype: Node object
+ """
+ return self.nodes[0]
+
def get_mac_addresses(self):
"""Gets MAC addresses from all nodes.
@@ -605,20 +619,6 @@ class Fabric(object):
return self._run_on_all_nodes(async, "get_server_ip", interface, ipv6,
user, password, aggressive)
- @property
- def primary_node(self):
- """The node to use for fabric config operations.
-
- Today, this is always node 0.
-
- >>> fabric.primary_node
- <cxmanage_api.node.Node object at 0x210d790>
-
- :return: Node object for primary node
- :rtype: Node object
- """
- return self.nodes[0]
-
def get_ipsrc(self):
"""Return the ipsrc for the fabric.
@@ -659,22 +659,6 @@ class Fabric(object):
"""
return self.primary_node.bmc.fabric_config_get_ip_addr_base()
- def _discover_nodes(self, ip_address, username="admin", password="admin"):
- """Gets the nodes of this fabric by pulling IP info from a BMC."""
- node = self.node(ip_address=ip_address, username=username,
- password=password, tftp=self.tftp,
- ecme_tftp_port=self.ecme_tftp_port,
- verbose=self.verbose)
- ipinfo = node.get_fabric_ipinfo()
- for node_id, node_address in ipinfo.iteritems():
- self._nodes[node_id] = self.node(ip_address=node_address,
- username=username,
- password=password,
- tftp=self.tftp,
- ecme_tftp_port=self.ecme_tftp_port,
- verbose=self.verbose)
- self._nodes[node_id].node_id = node_id
-
def update_config(self):
"""Push out updated configuration data for all nodes in the fabric.
@@ -899,5 +883,21 @@ class Fabric(object):
raise CommandFailedError(results, errors)
return results
+ def _discover_nodes(self, ip_address, username="admin", password="admin"):
+ """Gets the nodes of this fabric by pulling IP info from a BMC."""
+ node = self.node(ip_address=ip_address, username=username,
+ password=password, tftp=self.tftp,
+ ecme_tftp_port=self.ecme_tftp_port,
+ verbose=self.verbose)
+ ipinfo = node.get_fabric_ipinfo()
+ for node_id, node_address in ipinfo.iteritems():
+ self._nodes[node_id] = self.node(ip_address=node_address,
+ username=username,
+ password=password,
+ tftp=self.tftp,
+ ecme_tftp_port=self.ecme_tftp_port,
+ verbose=self.verbose)
+ self._nodes[node_id].node_id = node_id
+
# End of file: ./fabric.py