summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorda-woods <dw-git@d-woods.co.uk>2022-08-02 07:14:35 +0100
committerGitHub <noreply@github.com>2022-08-02 07:14:35 +0100
commit7034c959be052664f557128a9299f537b6632582 (patch)
treece106a6df0afb8c2a1253928681fe092334309f0
parent039a2c244361da1a6a16f28dc6478dd78438d0d5 (diff)
downloadcython-7034c959be052664f557128a9299f537b6632582.tar.gz
Apply suggestions from code review
Co-authored-by: scoder <stefan_ml@behnel.de>
-rw-r--r--Cython/Compiler/Parsing.py20
1 files changed, 9 insertions, 11 deletions
diff --git a/Cython/Compiler/Parsing.py b/Cython/Compiler/Parsing.py
index 70d4d26b3..d93b4aa64 100644
--- a/Cython/Compiler/Parsing.py
+++ b/Cython/Compiler/Parsing.py
@@ -4289,7 +4289,7 @@ def p_sequence_pattern(s):
if s.sy == closer:
break
else:
- if opener == ')' and len(patterns)==1:
+ if opener == ')' and len(patterns) == 1:
s.error("tuple-like pattern of length 1 must finish with ','")
break
s.expect(closer)
@@ -4326,12 +4326,11 @@ def p_mapping_pattern(s):
s.expect(':')
value = p_pattern(s)
items_patterns.append((key, value))
- if s.sy==',':
- s.next()
- else:
- break
- if s.sy=='}':
+ if s.sy != ',':
break
+ s.next()
+ if s.sy == '}':
+ break # Allow trailing comma.
s.expect('}')
if star_star_arg_pos is not None:
@@ -4378,12 +4377,11 @@ def p_class_pattern(s):
else:
with tentatively_scan(s) as errors:
keyword_patterns.append(p_keyword_pattern(s))
- if s.sy == ",":
- s.next()
- if s.sy == ")":
- break
- else:
+ if s.sy != ",":
break
+ s.next()
+ if s.sy == ")":
+ break # Allow trailing comma.
s.expect(")")
if keyword_patterns_error is not None: