From 45983898e9a7892ac0dba06660d9ed5fef766e02 Mon Sep 17 00:00:00 2001 From: Lisandro Dalcin Date: Mon, 3 Aug 2020 16:08:16 +0300 Subject: Fix unused variable warnings from C/C++ compilers in generated code * If both __setitem__ and __delitem__ special methods are defined, then there is no need to get the type name to report an unsupported operation. --- Cython/Compiler/ModuleNode.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Cython/Compiler/ModuleNode.py b/Cython/Compiler/ModuleNode.py index 64265e9af..9eb58513a 100644 --- a/Cython/Compiler/ModuleNode.py +++ b/Cython/Compiler/ModuleNode.py @@ -1866,8 +1866,9 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode): code.putln( "static int %s(PyObject *o, PyObject *i, PyObject *v) {" % ( scope.mangle_internal("mp_ass_subscript"))) - code.putln( - "__Pyx_TypeName o_type_name;") + if not set_entry or not del_entry: + code.putln( + "__Pyx_TypeName o_type_name;") code.putln( "if (v) {") if set_entry: @@ -1941,8 +1942,9 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode): code.putln( "static int %s(PyObject *o, Py_ssize_t i, Py_ssize_t j, PyObject *v) {" % ( scope.mangle_internal("sq_ass_slice"))) - code.putln( - "__Pyx_TypeName o_type_name;") + if not set_entry or not del_entry: + code.putln( + "__Pyx_TypeName o_type_name;") code.putln( "if (v) {") if set_entry: -- cgit v1.2.1