| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Indicate update failure with non-zero exit code
Closes #42
See merge request GNOME/dconf!34
|
| | |
| | |
| | |
| | | |
Fixes issue #42.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Consistently handle invalid database configuration by reporting the
error and continuing with remaining databases. Functional changes from
previous version:
* When loading key-file fails: no change.
* When group name is invalid: used to be ignored.
* When key name is invalid: used to fail on an assertion.
* When value is invalid: no change.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'011-dconf-update-is-not-correctly-checking-the-mtime-of-the-keyfiles' into 'master'
Check mtimes of files when updating databases
Closes #11
See merge request GNOME/dconf!27
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Do not check just mtimes of directories in /etc/dconf/db/
but also mtimes of the files in those directories
to catch all modifications in them.
https://bugzilla.gnome.org/show_bug.cgi?id=708258
Closes: https://gitlab.gnome.org/GNOME/dconf/issues/11
|
|\ \
| | |
| | |
| | |
| | | |
Add further integration tests
See merge request GNOME/dconf!33
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This make it possible to create integration tests for dconf update
without having access to SYSCONFDIR/dconf/db.
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
Coalesce pending writes into a single changeset
See merge request GNOME/dconf!30
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Reduce the number of in-flight requests to one, so as to increase
chances of merging pending requests. Drop the in-flight queue since
it is no longer useful, replacing it with optional changeset.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of queuing changes and sending them to a writer one by one,
coalesce them into a single changeset.
Coalescing changes requires a little bit more work on the client side,
see implementation of `dconf_changeset_change`, but it has chance to
substantially reduce the total amount of work necessary and avoid costly
disk writes.
|
|\ \
| | |
| | |
| | |
| | | |
Add integration tests
See merge request GNOME/dconf!31
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
ci: Always store test artifacts so we always get code coverage results
See merge request GNOME/dconf!32
|
|/ /
| |
| |
| | |
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|\ \
| | |
| | |
| | |
| | | |
Free OustandingWatch's path
See merge request GNOME/dconf!25
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise we leak it as can be seen in
https://source.puri.sm/guido.gunther/phosh/-/jobs/1868
This unbreaks phosh's CI build under valgrind.
|
|/ /
| |
| |
| | |
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|\ \
| | |
| | |
| | |
| | | |
Prepare 0.30 release
See merge request GNOME/dconf!24
|
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Prepare 0.29.2
See merge request GNOME/dconf!23
|
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Declare libdconf_service as a dependency
See merge request GNOME/dconf!22
|
|/ /
| |
| |
| | |
This reverts commit b799b08ec4e5978ab8db233a9da1532bf7918324.
|
| |
| |
| |
| | |
This reverts commit bf103302332603a637f1c33e603c93b82aa1dc0b.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The dconf-service internal static library depends on generated files,
and we need to make sure that those files are available by the time we
build the tests that depend on them, as Meson builds everything in
parallel. If we don't do that, in cases of massive parallelised
builders, we will end up with errors like:
```
ccache cc -Itests/tests@@writer@exe -Itests -I../tests -I. -I../ -Itests/../service -I../tests/../service -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g '-DSYSCONFDIR="/etc"' -fno-common -Wmissing-prototypes -Wwrite-strings -O2 -g -m64 -mtune=generic '-DSRCDIR="/ostbuild/source/dconf/tests"' -MD -MQ 'tests/tests@@writer@exe/writer.c.o' -MF 'tests/tests@@writer@exe/writer.c.o.d' -o 'tests/tests@@writer@exe/writer.c.o' -c ../tests/writer.c
../tests/writer.c:24:37: fatal error: service/dconf-generated.h: No such file or directory
```
Reviewed-by: nobody
Signed-off-by: Emmanuele Bassi <ebassi@gnome.org>
|
|\ \
| | |
| | |
| | |
| | | |
service: Allow opening corrupt GVDB files when writing
See merge request GNOME/dconf!8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It’s a little counterintuitive that a function called ‘read’ could
sometimes move a file (which could be considered a write).
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise the tests fail now that we’re compiling with
G_LOG_USE_STRUCTURED.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use g_test_subprocess() and g_test_trap_subprocess() instead. This
requires splitting up some of the unit tests, since subprocesses are
handled at a per-test level, and you can’t trivially fork multiple
different subprocesses from a single test (like you could with fork()).
While fork was safe to use on POSIX (and dconf only targets POSIX), the
fact that we had to redefine GLIB_VERSION_MIN_REQUIRED to hide the
deprecation errors was not doing wonders for the maintainability of the
tests.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This enables structured logging for all parts of dconf, which will make
it easier to check for certain log messages in the unit tests.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
This will make unit testing the code easier.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This doesn’t bump our GLib dependency, since we already depend on GLib
2.44.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a GVDB file cannot be opened due to being corrupt, move it out of the
way, warn, and open a new blank database instead.
This prevents the situation where a corrupt database stops the entire
desktop session from loading.
Note that the dconf_gvdb_utils_read_file() code path is only taken
inside DConfWriter. The DConf engine sources (such as
dconf-engine-source-system.c) open the GVDB tables separately, and
already all handle errors gracefully.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://gitlab.gnome.org/GNOME/glib/issues/1454
|
|\ \
| | |
| | |
| | |
| | | |
Replace all hard-coded /etc path with sysconfdir
See merge request GNOME/dconf!21
|
|/ /
| |
| |
| |
| |
| |
| | |
This is useful for JHBuild environments and systems that don't want
to use /etc/dconf.
https://bugzilla.gnome.org/show_bug.cgi?id=739299
|
|\ \
| | |
| | |
| | |
| | | |
Engine: Change overflow thresholds in subscription counts from GMAXUINT32 to GMAXUINT
See merge request GNOME/dconf!20
|