summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2018-03-09 13:47:37 +1100
committerDavid Gibson <david@gibson.dropbear.id.au>2018-03-09 14:01:51 +1100
commit14a3002a1aee3224cc0db437ee41d3b90a9cef45 (patch)
tree7be67b174b0dac93c75186c77c7d4ea09fcd9717
parent02c5fe9debc0e31e97ee0f158627d5cb512c7940 (diff)
downloaddevice-tree-compiler-14a3002a1aee3224cc0db437ee41d3b90a9cef45.tar.gz
tests: Update valgrind suppressions for sw_tree1
This test builds a tree in a previously uninitialized buffer, then writes the whole buffer out to a file to be used by other tests. Because part of the buffer may be uninitialized this causes a valgrind error. Pre-initializing the buffer would remove the error, however it would make valgrind not notice any accesses to the uninitialized portion *before* the write out, and those would be genuine errors. So, instead we use a valgrind suppressions file - however it has a couple of problems. First it unnecessarily lists the same call path twice. Second, the call path is only right for some C library versions. Change the second copy to cover possible path that occurs with a different glibc version. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
-rw-r--r--tests/sw_tree1.supp2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/sw_tree1.supp b/tests/sw_tree1.supp
index 279f9e5..fcb1950 100644
--- a/tests/sw_tree1.supp
+++ b/tests/sw_tree1.supp
@@ -11,7 +11,7 @@
allocation methods causes uninitialized data in alignment gap
Memcheck:Param
write(buf)
- fun:__write_nocancel
+ fun:write
fun:utilfdt_write_err
fun:save_blob
fun:main