diff options
| author | Jean-Christophe Dubois <jcd@tribudubois.net> | 2017-02-07 22:26:25 +0100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2017-02-08 17:37:21 +1100 |
| commit | 95d57726bca42fdedf63178a46a15599c02b60cc (patch) | |
| tree | 6ea2bfde019f062cbc5d4922740c02d790eff4c6 /livetree.c | |
| parent | 3b9c97093d6e1067f4d24d2bff32f3dd24e0751e (diff) | |
| download | device-tree-compiler-95d57726bca42fdedf63178a46a15599c02b60cc.tar.gz | |
livetree.c: Fix memory leak
When running coverity on dtc source code the following error is reported.
==========================================================================
*** CID 1370967: Resource leaks (RESOURCE_LEAK)
/tools/dtc/livetree.c: 850 in add_fixup_entry()
844 if (strchr(node->fullpath, ':') || strchr(prop->name, ':'))
845 die("arguments should not contain ':'\n");
846
847 xasprintf(&entry, "%s:%s:%u",
848 node->fullpath, prop->name, m->offset);
849 append_to_property(fn, m->ref, entry, strlen(entry) + 1);
>>> CID 1370967: Resource leaks (RESOURCE_LEAK)
>>> Variable "entry" going out of scope leaks the storage it points to.
850 }
==========================================================================
Fix the leak.
Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'livetree.c')
| -rw-r--r-- | livetree.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -847,6 +847,8 @@ static void add_fixup_entry(struct dt_info *dti, struct node *fn, xasprintf(&entry, "%s:%s:%u", node->fullpath, prop->name, m->offset); append_to_property(fn, m->ref, entry, strlen(entry) + 1); + + free(entry); } static void generate_fixups_tree_internal(struct dt_info *dti, |