summaryrefslogtreecommitdiff
path: root/util.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2019-07-28 16:25:51 +1000
committerDavid Gibson <david@gibson.dropbear.id.au>2019-07-28 16:31:44 +1000
commitb8d6eca78210952c6d93235c38ebd5836d6409c4 (patch)
tree6c01595b68f42cc955e2906786180430636ef7c4 /util.c
parent184f51099471341715bc81a4c09b56a3c6f9d687 (diff)
downloaddevice-tree-compiler-b8d6eca78210952c6d93235c38ebd5836d6409c4.tar.gz
libfdt: Allow #size-cells of 0
c12b2b0c20eb "libfdt: fdt_address_cells() and fdt_size_cells()" introduced a bug as it consolidated code between the helpers for getting #address-cells and #size-cells. Specifically #size-cells is allowed to be 0, and is frequently found so in practice for /cpus. IEEE1275 only requires implementations to handle 1..4 for #address-cells, although one could make a case for #address-cells == #size-cells == 0 being used to represent a bridge with a single port. While we're there, it's not totally obvious that the existing implicit cast of a u32 to int will give the correct results according to strict C, although it does work in practice. Straighten that up to cast only after we've made our range checks. Reported-by: yonghuhaige via https://github.com/dgibson/dtc/issues/28 Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'util.c')
0 files changed, 0 insertions, 0 deletions