diff options
author | Joffrey F <joffrey@docker.com> | 2017-08-15 17:40:07 -0700 |
---|---|---|
committer | Joffrey F <f.joffrey@gmail.com> | 2017-08-17 13:38:40 -0700 |
commit | d5c4ce203aa5839966a221079d1be44e572e92af (patch) | |
tree | ecaa4b94096c667b2541ab5ee21e0413a6b74434 | |
parent | 6b59dc62715a1e387543de02ade80de84aa2171c (diff) | |
download | docker-py-d5c4ce203aa5839966a221079d1be44e572e92af.tar.gz |
Use better version comparison function
Signed-off-by: Joffrey F <joffrey@docker.com>
-rw-r--r-- | docker/models/containers.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/docker/models/containers.py b/docker/models/containers.py index d9db79d..688decc 100644 --- a/docker/models/containers.py +++ b/docker/models/containers.py @@ -4,7 +4,7 @@ from ..api import APIClient from ..errors import (ContainerError, ImageNotFound, create_unexpected_kwargs_error) from ..types import HostConfig -from ..utils import compare_version +from ..utils import version_gte from .images import Image from .resource import Collection, Model @@ -691,8 +691,7 @@ class ContainerCollection(Collection): image = image.id detach = kwargs.pop("detach", False) if detach and remove: - if compare_version("1.24", - self.client.api._version) > 0: + if version_gte(self.client.api._version, '1.25'): kwargs["auto_remove"] = True else: raise RuntimeError("The options 'detach' and 'remove' cannot " |